Simplify annotations in runtime check tests.

Simplify annotations in runtime check tests.

It turns out that it is easier to calculate whether or not checks are
needed at the site of the declaration of the interface target, not at
the call site.  Accordingly, it makes sense to put the annotations on
the interface target declarations as well.  This lets us get rid of a
clumsy annotation format that referred to arguments by number, in
favor of simply annotating the formal parameters themselves.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c3ae6bd2963025a9cb31c037d01503325633ac9d

[Paul Berry, 2017-08-29 23:43:50]

paulberry@google.com changed reviewers:
+ scheglov@google.com, sigmund@google.com

[Paul Berry, 2017-08-29 23:43:51]

I only need a review from one of you.

[scheglov, 2017-08-30 04:07:54]

lgtm

https://codereview.chromium.org/3010613003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/3010613003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:880: new
InstrumentationValueLiteral('closure'));
Do you mean "this"?

[Paul Berry, 2017-08-30 17:55:33]

https://codereview.chromium.org/3010613003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/3010613003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:880: new
InstrumentationValueLiteral('closure'));
On 2017/08/30 04:07:54, scheglov wrote:
> Do you mean "this"?

Yes, thank you.  Eventually the tests in pkg/front_end/testcases/runtime_checks
would have caught this, but I guess I don't yet have enough functionality
working to catch this case yet :)

Fixed.

[Paul Berry, 2017-08-30 18:05:21]

Description was changed from

==========
Simplify annotations in runtime check tests.

It turns out that it is easier to calculate whether or not checks are
needed at the site of the declaration of the interface target, not at
the call site.  Accordingly, it makes sense to put the annotations on
the interface target declarations as well.  This lets us get rid of a
clumsy annotation format that referred to arguments by number, in
favor of simply annotating the formal parameters themselves.
==========

to

==========
Simplify annotations in runtime check tests.

It turns out that it is easier to calculate whether or not checks are
needed at the site of the declaration of the interface target, not at
the call site.  Accordingly, it makes sense to put the annotations on
the interface target declarations as well.  This lets us get rid of a
clumsy annotation format that referred to arguments by number, in
favor of simply annotating the formal parameters themselves.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c3ae6bd2963025a9cb31c037d01503325633ac9d
==========

[Paul Berry, 2017-08-30 18:05:22]

Committed patchset #3 (id:40001) manually as
c3ae6bd2963025a9cb31c037d01503325633ac9d (presubmit successful).