pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart - Issue 3010613003: Simplify annotations in runtime check tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart

Issue 3010613003: Simplify annotations in runtime check tests. (Closed)

Patch Set: Address code review comment Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/testcases/runtime_checks/contravariant_getter.dart ('k') | pkg/front_end/testcases/runtime_checks/covariant_generic_parameter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart

diff --git a/pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart b/pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart

index 843054753f085a081a5606319cd9532d7882e618..01f572253870b994b6426def91c7f898da97ecab 100644

--- a/pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart

+++ b/pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart

@@ -6,19 +6,21 @@

library test;

class C<T> {

- void f< /*@checkFormal=semiSafe*/ U extends T>(U x) {}

- void g1< /*@checkFormal=semiSafe*/ U extends T>() {

- this.f<U>(1.5);

+ void f< /*@checkFormal=semiSafe*/ /*@checkInterface=semiTyped*/ U extends T>(

+ U x) {}

+ void

+ g1< /*@checkFormal=semiSafe*/ /*@checkInterface=semiTyped*/ U extends T>() {

+ this.f<U> /*@callKind=this*/ (1.5);

}

void g2(C<Object> c) {

- c.f<num> /*@checkCall=interface(semiTyped:<0>)*/ (1.5);

+ c.f<num>(1.5);

}

void test() {

- new C<int>().g1<num> /*@checkCall=interface(semiTyped:<0>)*/ ();

- g2(new C<int>()); // runtime error

+ new C<int>().g1<num>();

+ g2(new C<int>());

}

void main() {}