pkg/front_end/lib/src/base/processed_options.dart - Issue 3010033002: don't use internal throwOnWarnings option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/base/processed_options.dart

Issue 3010033002: don't use internal throwOnWarnings option (Closed)

Patch Set: wait until all errors are processed before failing Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/base/processed_options.dart

diff --git a/pkg/front_end/lib/src/base/processed_options.dart b/pkg/front_end/lib/src/base/processed_options.dart

index 209af26433bc071c6d35b601c6aa024c2536c004..046bc720b482cb0bd8dc5dcab9665df57921fd84 100644

--- a/pkg/front_end/lib/src/base/processed_options.dart

+++ b/pkg/front_end/lib/src/base/processed_options.dart

@@ -613,8 +613,9 @@ class _CompilationMessage implements CompilationMessage {

String get dart2jsCode => _original.code.dart2jsCode;

- SourceSpan get span =>

- new SourceLocation(_original.charOffset, sourceUrl: _original.uri)

+ SourceSpan get span => _original.charOffset == -1

+ ? null

Siggi Cherem (dart-lang) 2017/09/01 20:34:34 If _original.uri is not null, maybe use SourceLoca

+ : new SourceLocation(_original.charOffset, sourceUrl: _original.uri)

.pointSpan();

_CompilationMessage(this._original, this.severity);

« no previous file with comments | « no previous file | pkg/front_end/tool/bazel/worker.dart » ('j') | no next file with comments »