Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: pkg/front_end/lib/src/base/processed_options.dart

Issue 3010033002: don't use internal throwOnWarnings option (Closed)
Patch Set: wait until all errors are processed before failing Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/front_end/tool/bazel/worker.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 6
7 import 'package:front_end/compilation_message.dart'; 7 import 'package:front_end/compilation_message.dart';
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/file_system.dart'; 9 import 'package:front_end/file_system.dart';
10 import 'package:front_end/src/base/performace_logger.dart'; 10 import 'package:front_end/src/base/performace_logger.dart';
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 final Severity severity; 606 final Severity severity;
607 607
608 String get message => _original.message; 608 String get message => _original.message;
609 609
610 String get tip => _original.tip; 610 String get tip => _original.tip;
611 611
612 String get analyzerCode => _original.code.analyzerCode; 612 String get analyzerCode => _original.code.analyzerCode;
613 613
614 String get dart2jsCode => _original.code.dart2jsCode; 614 String get dart2jsCode => _original.code.dart2jsCode;
615 615
616 SourceSpan get span => 616 SourceSpan get span => _original.charOffset == -1
617 new SourceLocation(_original.charOffset, sourceUrl: _original.uri) 617 ? null
Siggi Cherem (dart-lang) 2017/09/01 20:34:34 If _original.uri is not null, maybe use SourceLoca
618 : new SourceLocation(_original.charOffset, sourceUrl: _original.uri)
618 .pointSpan(); 619 .pointSpan();
619 620
620 _CompilationMessage(this._original, this.severity); 621 _CompilationMessage(this._original, this.severity);
621 622
622 String toString() => message; 623 String toString() => message;
623 } 624 }
OLDNEW
« no previous file with comments | « no previous file | pkg/front_end/tool/bazel/worker.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698