don't use internal throwOnWarnings option

don't use internal throwOnWarnings option

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/91c9de2ac2f4055f10b6793b549cf89737aa1056

[jakemac, 2017-09-01 17:11:06]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-09-01 17:19:09]

lgtm with suggestion

https://codereview.chromium.org/3010033002/diff/1/pkg/front_end/tool/bazel/wo...
File pkg/front_end/tool/bazel/worker.dart (right):

https://codereview.chromium.org/3010033002/diff/1/pkg/front_end/tool/bazel/wo...
pkg/front_end/tool/bazel/worker.dart:101: throw error;
Instead of throwing here, consider setting a boolean that indicates that errors
were seen. Then throw right after `summaryFor`?

That way you can report all errors that come up, and not just the first one.

[jakemac, 2017-09-01 20:29:59]

On 2017/09/01 17:19:09, Siggi Cherem (dart-lang) wrote:
> lgtm with suggestion
> 
>
https://codereview.chromium.org/3010033002/diff/1/pkg/front_end/tool/bazel/wo...
> File pkg/front_end/tool/bazel/worker.dart (right):
> 
>
https://codereview.chromium.org/3010033002/diff/1/pkg/front_end/tool/bazel/wo...
> pkg/front_end/tool/bazel/worker.dart:101: throw error;
> Instead of throwing here, consider setting a boolean that indicates that
errors
> were seen. Then throw right after `summaryFor`?
> 
> That way you can report all errors that come up, and not just the first one.

Done

[Siggi Cherem (dart-lang), 2017-09-01 20:34:34]

minor suggestion below, but otherwise LGTM

https://codereview.chromium.org/3010033002/diff/20001/pkg/front_end/lib/src/b...
File pkg/front_end/lib/src/base/processed_options.dart (right):

https://codereview.chromium.org/3010033002/diff/20001/pkg/front_end/lib/src/b...
pkg/front_end/lib/src/base/processed_options.dart:617: ? null
If _original.uri is not null, maybe use SourceLocation(0, sourceUrl:
_original.uri) instead?

[jakemac, 2017-09-01 20:51:58]

updated

[jakemac, 2017-09-01 20:52:54]

Description was changed from

==========
don't use internal throwOnWarnings option

BUG=
==========

to

==========
don't use internal throwOnWarnings option

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/91c9de2ac2f4055f10b6793b549cf89737aa1056
==========

[jakemac, 2017-09-01 20:52:56]

Committed patchset #3 (id:40001) manually as
91c9de2ac2f4055f10b6793b549cf89737aa1056 (presubmit successful).