Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3009893002: Avoid relying on fuzzy arrow for arity check in _FutureListener (Closed)

Created:
3 years, 3 months ago by Leaf
Modified:
3 years, 3 months ago
CC:
dev-compiler+reviews_dartlang.org, Lasse Reichstein Nielsen, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid relying on fuzzy arrow for arity check in _FutureListener BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/f606e559c5b834ecd4d9597f9ca0ced6cbc59188

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/async/future_impl.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
Leaf
3 years, 3 months ago (2017-08-30 21:08:55 UTC) #2
Jennifer Messerly
lgtm
3 years, 3 months ago (2017-08-30 21:18:24 UTC) #3
Leaf
Committed patchset #1 (id:1) manually as f606e559c5b834ecd4d9597f9ca0ced6cbc59188 (presubmit successful).
3 years, 3 months ago (2017-08-30 21:19:02 UTC) #5
floitsch
3 years, 3 months ago (2017-08-31 07:54:53 UTC) #7
Message was sent while issue was closed. 
LGTM.

https://codereview.chromium.org/3009893002/diff/1/sdk/lib/async/future_impl.dart
File sdk/lib/async/future_impl.dart (right):

https://codereview.chromium.org/3009893002/diff/1/sdk/lib/async/future_impl.d...
sdk/lib/async/future_impl.dart:139: if (errorCallback is
ZoneBinaryCallback<dynamic, Null, Null>) {
Might as well use the correct type (see 2 lines below).

Powered by Google App Engine
This is Rietveld 408576698