sdk/lib/async/future_impl.dart - Issue 3009893002: Avoid relying on fuzzy arrow for arity check in _FutureListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/future_impl.dart

Issue 3009893002: Avoid relying on fuzzy arrow for arity check in _FutureListener (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/async/future_impl.dart

diff --git a/sdk/lib/async/future_impl.dart b/sdk/lib/async/future_impl.dart

index 14bac61ce77aeb5293a51c7d00c05f6ef4378dc9..8569cbf7a82277d1d8768148f0a5672669c2630a 100644

--- a/sdk/lib/async/future_impl.dart

+++ b/sdk/lib/async/future_impl.dart

@@ -136,7 +136,7 @@ class _FutureListener<S, T> {

FutureOr<T> handleError(AsyncError asyncError) {

assert(handlesError && hasErrorCallback);

- if (errorCallback is ZoneBinaryCallback) {

+ if (errorCallback is ZoneBinaryCallback<dynamic, Null, Null>) {

floitsch 2017/08/31 07:54:52 Might as well use the correct type (see 2 lines be

var typedErrorCallback = errorCallback as Object

/*=ZoneBinaryCallback<FutureOr<T>, Object, StackTrace>*/;

return _zone.runBinary(

« no previous file with comments | « no previous file | no next file » | no next file with comments »