Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 3009883002: Remove ShadowVariableDeclaration.isSemiSafe. (Closed)

Created:
3 years, 3 months ago by Paul Berry
Modified:
3 years, 3 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ShadowVariableDeclaration.isSemiSafe. This only existed as a temporary measure while we were discussing how to modify the kernel format. It has been replaced by VariableDeclaration.formalSafety. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b8e5e03ff4aff67c2221d576781c896290ae9d8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Paul Berry
I only need a review from one of you.
3 years, 3 months ago (2017-08-30 21:01:10 UTC) #3
scheglov
LGTM
3 years, 3 months ago (2017-08-30 21:04:53 UTC) #4
Paul Berry
3 years, 3 months ago (2017-08-30 21:38:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8e5e03ff4aff67c2221d576781c896290ae9d8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698