Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

Issue 3009883002: Remove ShadowVariableDeclaration.isSemiSafe. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
index 31d8d4f332e48903cd6000662d171f6333babee3..d99b0633ed06d6bdf2110c5948f759aaebf95dec 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
@@ -16,6 +16,7 @@ import 'package:kernel/ast.dart'
DartType,
DynamicType,
Field,
+ FormalSafety,
FunctionType,
InterfaceType,
Location,
@@ -311,10 +312,9 @@ abstract class TypeInferenceEngineImpl extends TypeInferenceEngine {
for (var procedure in cls.procedures) {
if (procedure.isStatic) continue;
void compute(VariableDeclaration formal) {
- ShadowVariableDeclaration kernelVariableDeclaration = formal;
var pessimisticType = pessimization.substituteType(formal.type);
if (!typeSchemaEnvironment.isSubtypeOf(formal.type, pessimisticType)) {
- kernelVariableDeclaration.isSemiSafe = true;
+ formal.formalSafety = FormalSafety.semiSafe;
instrumentation?.record(Uri.parse(cls.fileUri), formal.fileOffset,
'checkFormal', new InstrumentationValueLiteral('semiSafe'));
instrumentation?.record(Uri.parse(cls.fileUri), formal.fileOffset,
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698