Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 3009593002: It's alive (first kernel inference test) (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -92 lines) Patch
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 4 chunks +70 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 2 chunks +28 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 3 chunks +11 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 2 chunks +46 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +1 line, -2 lines 0 comments Download
A + tests/compiler/dart2js/inference/data/return.dart View 1 chunk +1 line, -11 lines 0 comments Download
A + tests/compiler/dart2js/inference/data/simple.dart View 1 chunk +1 line, -13 lines 0 comments Download
M tests/compiler/dart2js/inference/data/super_get.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 3 months ago (2017-08-25 16:46:37 UTC) #2
Siggi Cherem (dart-lang)
woo hoo! lgtm https://codereview.chromium.org/3009593002/diff/1/pkg/compiler/lib/src/js_model/closure.dart File pkg/compiler/lib/src/js_model/closure.dart (right): https://codereview.chromium.org/3009593002/diff/1/pkg/compiler/lib/src/js_model/closure.dart#newcode196 pkg/compiler/lib/src/js_model/closure.dart:196: /*assert( TODO? does it happen because ...
3 years, 3 months ago (2017-08-25 18:19:11 UTC) #3
Johnni Winther
https://codereview.chromium.org/3009593002/diff/1/pkg/compiler/lib/src/js_model/closure.dart File pkg/compiler/lib/src/js_model/closure.dart (right): https://codereview.chromium.org/3009593002/diff/1/pkg/compiler/lib/src/js_model/closure.dart#newcode196 pkg/compiler/lib/src/js_model/closure.dart:196: /*assert( On 2017/08/25 18:19:11, Siggi Cherem (dart-lang) wrote: > ...
3 years, 3 months ago (2017-08-25 18:32:20 UTC) #4
Johnni Winther
3 years, 3 months ago (2017-08-29 08:13:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d9dd35f1cac143ff0d18c4e8d3210c1f509579b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698