It's alive (first kernel inference test)

pkg/compiler/lib/src/js_model/closure.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../closure.dart';
 import '../common.dart';
 import '../common/tasks.dart';
 import '../constants/expressions.dart';
@@ skipping 175 matching lines @@
 
   @override
   // TODO(efortuna): Eventually capturedScopesMap[node] should always
   // be non-null, and we should just test that with an assert.
   CapturedLoopScope getCapturedLoopScope(ir.Node loopNode) =>
       _capturedScopesMap[loopNode] ?? const CapturedLoopScope();
 
   @override
   ClosureRepresentationInfo getClosureInfoForMember(MemberEntity entity) {
     var closure = _memberClosureRepresentationMap[entity];
-    assert(
+    /*assert(

[Siggi Cherem (dart-lang), 2017/08/25 18:19:11]

TODO? does it happen because of some of the changes Emily has in the works?

[Johnni Winther, 2017/08/25 18:32:20]

Adding a TODO. We are moving towards using getScopeInfo instead.

         closure != null,
         "Corresponding closure class not found for $entity. "
-        "Closures found for ${_memberClosureRepresentationMap.keys}");
-    return closure;
+        "Closures found for ${_memberClosureRepresentationMap.keys}");*/
+    return closure ?? const ClosureRepresentationInfo();
   }
 
   @override
   ClosureRepresentationInfo getClosureInfo(ir.Node node) {
     var closure = _localClosureRepresentationMap[node];
     assert(
         closure != null,
         "Corresponding closure class not found for $node. "
         "Closures found for ${_localClosureRepresentationMap.keys}");
     return closure;
@@ skipping 308 matching lines @@
 class ClosureFieldData extends ClosureMemberData implements FieldData {
   ClosureFieldData(MemberDefinition definition) : super(definition);
 
   @override
   DartType getFieldType(KernelToElementMap elementMap) {
     // A closure field doesn't have a Dart type.
     return null;
   }
 
   @override
-  ConstantExpression getFieldConstant(
-      KernelToElementMap elementMap, FieldEntity field) {
+  ConstantExpression getFieldConstantExpression(KernelToElementMap elementMap) {
     failedAt(
-        field,
-        "Unexpected field $field in "
-        "ClosureFieldData.getFieldConstant");
+        definition.member,
+        "Unexpected field ${definition.member} in "
+        "ClosureFieldData.getFieldConstantExpression");
+    return null;
+  }
+
+  @override
+  ConstantValue getConstantFieldInitializer(KernelToElementMap elementMap) {
+    failedAt(
+        definition.member,
+        "Unexpected field ${definition.member} in "
+        "ClosureFieldData.getConstantFieldInitializer");
+    return null;
+  }
+
+  @override
+  bool hasConstantFieldInitializer(KernelToElementMap elementMap) {
+    return false;
+  }
+
+  @override
+  ConstantValue getFieldConstantValue(KernelToElementMap elementMap) {
     return null;
   }
 }
 
 class ClosureMemberDefinition implements MemberDefinition {
   final MemberEntity member;
   final SourceSpan location;
   final MemberKind kind;
   final ir.Node node;
 
   ClosureMemberDefinition(this.member, this.location, this.kind, this.node);
 
   String toString() =>
       'ClosureMemberDefinition(kind:$kind,member:$member,location:$location)';
 }
 
 /// Collection of scope data collected for a single member.
 class ScopeModel {
   /// Collection [ScopeInfo] data for the member.
   KernelScopeInfo scopeInfo;
 
   /// Collected [CapturedScope] data for nodes.
   Map<ir.Node, KernelCapturedScope> capturedScopesMap =
       <ir.Node, KernelCapturedScope>{};
 
   /// Collected [ScopeInfo] data for nodes.
   Map<ir.FunctionNode, KernelScopeInfo> closuresToGenerate =
       <ir.FunctionNode, KernelScopeInfo>{};
 }