Modify blink type map to finalize lazily

Modify blink type map to finalize lazily

Ivan suggested altering our type maps to add a level of indirection - to avoid eagerly finalizing all classes.

Siva: not sure how you're instrumenting startup - can you test this out?

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37222

[vsm, 2014-05-28 15:07:45]

https://codereview.chromium.org/300923003/diff/30001/sdk/lib/_blink/dartium/_...
File sdk/lib/_blink/dartium/_blink_dartium.dart (right):

https://codereview.chromium.org/300923003/diff/30001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:8300: if
(htmlBlinkMap.containsKey(key))
If initializing htmlBlinkMap is too expensive, we could add a shortcut map with
only common types (e.g., "Window", "HTMLDocument", "Console").

[siva, 2014-05-30 23:53:33]

Vijay, I could not get a measure of the speed up this change would introduce
because when I tried to patch your change into a top of tree dartium 36 client I
had and the browser was crashing when I tried to run the empty script html. The
backtrace was as follows:

Program received signal SIGABRT, Aborted.
[Switching to Thread 0x7fffcd115700 (LWP 23389)]
0x00007ffff1701425 in __GI_raise (sig=<optimized out>)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
64	../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) where
#0  0x00007ffff1701425 in __GI_raise (sig=<optimized out>)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00007ffff1704b8b in __GI_abort () at abort.c:91
#2  0x0000555559e3816a in dart::DynamicAssertionHelper::Fail(char const*, ...)
    ()
#3  0x0000555559c762fc in Dart_SetReturnValue ()
#4  0x0000555557e15bdb in
WebCore::DartNativeUtilitiesInternal::topLevelWindow(_Dart_NativeArguments*) ()
#5  0x0000555559e61704 in
dart::NativeEntry::NativeCallWrapper(_Dart_NativeArguments*, void
(*)(_Dart_NativeArguments*)) ()
#6  0x00007fffca58139c in ?? ()
#7  0x00000e76a1e04400 in ?? ()
#8  0x0000000004000000 in ?? ()
#9  0x00007fffcd113ff8 in ?? ()
#10 0x00007fffcd113fd8 in ?? ()

https://codereview.chromium.org/300923003/diff/30001/sdk/lib/_blink/dartium/_...
File sdk/lib/_blink/dartium/_blink_dartium.dart (right):

https://codereview.chromium.org/300923003/diff/30001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:8300: if
(htmlBlinkMap.containsKey(key))
If we are going to go with specialization for certain types I would prefer if we
wired them up so that we can access them from C++ code itself without having to
make a Dart call.

The cost of making a Dart call is not just limited to the class finalization it
also involves transition to Dart, parsing the code, generating m/c code and
transitioning back.

On 2014/05/28 15:07:45, vsm wrote:
> If initializing htmlBlinkMap is too expensive, we could add a shortcut map
with
> only common types (e.g., "Window", "HTMLDocument", "Console").

[siva, 2014-06-03 22:03:15]

lgtm

[siva, 2014-06-06 22:41:04]

Vijay, are you not going to submit this CL ?

[vsm, 2014-06-11 05:48:47]

Committed patchset #8 manually as r37222 (presubmit successful).