Add external sizes to the heap dominator tree.

Add external sizes to the heap dominator tree.

Fixes #30381

R=cbernaschina@google.com

Committed: https://github.com/dart-lang/sdk/commit/48bc6e5d738c4900111dfabefe8a257e641a1c96

[rmacnak, 2017-08-26 00:54:02]

rmacnak@google.com changed reviewers:
+ asiva@google.com, cbernaschina@google.com

[cbernaschina, 2017-08-28 16:15:19]

LGTM with some questions

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/object_graph.dart (right):

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/object_graph.dart:581: assert(id == (N + 1));
Is this assertion still needed?

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/pub...
File runtime/observatory/pubspec.yaml (right):

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/pub...
runtime/observatory/pubspec.yaml:7: minify: false
Are you sure that this is not going to be applied even during the production of
the runtime binaries?

[rmacnak, 2017-08-28 17:08:20]

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/object_graph.dart (right):

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/object_graph.dart:581: assert(id == (N + 1));
On 2017/08/28 16:15:18, cbernaschina wrote:
> Is this assertion still needed?

No, this isn't useful anymore. Removed.

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/pub...
File runtime/observatory/pubspec.yaml (right):

https://codereview.chromium.org/3008593002/diff/40001/runtime/observatory/pub...
runtime/observatory/pubspec.yaml:7: minify: false
On 2017/08/28 16:15:18, cbernaschina wrote:
> Are you sure that this is not going to be applied even during the production
of
> the runtime binaries?

Reverted.

[rmacnak, 2017-08-28 17:54:37]

Description was changed from

==========
Add external sizes to the heap dominator tree.

Fixes #30381
==========

to

==========
Add external sizes to the heap dominator tree.

Fixes #30381

R=cbernaschina@google.com

Committed:
https://github.com/dart-lang/sdk/commit/48bc6e5d738c4900111dfabefe8a257e641a1c96
==========

[rmacnak, 2017-08-28 17:54:38]

Committed patchset #4 (id:60001) manually as
48bc6e5d738c4900111dfabefe8a257e641a1c96 (presubmit successful).