Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart

Issue 3008593002: Add external sizes to the heap dominator tree. (Closed)
Patch Set: review Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/object_graph.dart ('k') | runtime/vm/object_graph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart
diff --git a/runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart b/runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart
index 5f0bd3eb4d86e8b1585510839ce859a2b909b9f6..37c6bf56410f98611dc21caf071fdfd21e1ac6df 100644
--- a/runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart
+++ b/runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart
@@ -9,7 +9,7 @@ class HeapSnapshot implements M.HeapSnapshot {
DateTime timestamp;
int get objects => graph.vertexCount;
int get references => graph.edgeCount;
- int get size => graph.size;
+ int get size => graph.internalSize + graph.externalSize;
HeapSnapshotDominatorNode dominatorTree;
HeapSnapshotMergedDominatorNode mergedDominatorTree;
List<MergedVertex> classReferences;
@@ -150,6 +150,7 @@ class HeapSnapshotDominatorNode implements M.HeapSnapshotDominatorNode {
int get retainedSize => v.retainedSize;
int get shallowSize => v.shallowSize;
+ int get externalSize => v.externalSize;
HeapSnapshotDominatorNode(S.Isolate isolate, ObjectVertex vertex)
: isolate = isolate,
@@ -182,6 +183,7 @@ class HeapSnapshotMergedDominatorNode
int get instanceCount => v.instanceCount;
int get retainedSize => v.retainedSize;
int get shallowSize => v.shallowSize;
+ int get externalSize => v.externalSize;
HeapSnapshotMergedDominatorNode(S.Isolate isolate, MergedObjectVertex vertex)
: isolate = isolate,
« no previous file with comments | « runtime/observatory/lib/object_graph.dart ('k') | runtime/vm/object_graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698