Removed Dartium SDK libs

Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
Committed: https://github.com/dart-lang/sdk/commit/d96561af083777ac9529c75ae05b6e89f8f06a6c
Committed: https://github.com/dart-lang/sdk/commit/4a5891838274ac53124acf6905c8ac9121978470

[terry, 2017-08-29 13:39:00]

Description was changed from

==========
Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com
==========

to

==========
Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
==========

[terry, 2017-08-29 13:39:02]

Committed patchset #19 (id:180001) manually as
a18908461adc431af2ee0114ed5ea9ef781bfb67 (presubmit successful).

[zra, 2017-08-29 21:06:03]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2017-08-29 21:06:04]

Where is the code review for this CL?

[terry, 2017-08-30 22:37:07]

terry@google.com changed reviewers:
+ asiva@google.com, sigmund@google.com
- zra@google.com

[terry, 2017-08-30 22:37:09]

I'll be submitting this to the bots tonight to validate that nothing is broken.

Siva could you review the runtime dir changes.

Siggi could you review the library.dart file changes.

Alan can you review everything else the deleted files or the dartium libraries. 
Only nativewrappers.dart is still in a dartium subdirectory.  I'll be moving
that out to a different directory in a subsequent CL and also flattening out the
dart2js subdirs in sdk/lib in a subsequent CL.

Thanks.

[siva, 2017-08-30 22:45:24]

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (left):

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/BUILD.gn#o...
runtime/bin/BUILD.gn:185: 
I think you should check with jacobr@ and matanl@ before removing support for
these. Apparently there are some users in Google3 who like to run the command
line dart against code that imports some of these html libraries.

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/builtin.h
File runtime/bin/builtin.h (left):

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/builtin.h#...
runtime/bin/builtin.h:83: static const char* web_audio_source_paths_[];
Ditto comment about removing these.

[Alan Knight, 2017-08-30 22:54:50]

https://codereview.chromium.org/3008563002/diff/210001/sdk/lib/html/html_comm...
File sdk/lib/html/html_common/html_common.dart (right):

https://codereview.chromium.org/3008563002/diff/210001/sdk/lib/html/html_comm...
sdk/lib/html/html_common/html_common.dart:26: part 'conversions_dart2js.dart';
Wait, how did this work at all if it was explicitly importing the dartium
version for both before?

https://codereview.chromium.org/3008563002/diff/210001/tests/lib/analyzer/ana...
File tests/lib/analyzer/analyze_library.status (left):

https://codereview.chromium.org/3008563002/diff/210001/tests/lib/analyzer/ana...
tests/lib/analyzer/analyze_library.status:26:
lib/js_util/dart2js/js_util_dart2js: CompileTimeError # Issue 16522
How does removing Dartium code affect this?

https://codereview.chromium.org/3008563002/diff/210001/tools/patch_sdk.dart
File tools/patch_sdk.dart (right):

https://codereview.chromium.org/3008563002/diff/210001/tools/patch_sdk.dart#n...
tools/patch_sdk.dart:46: if (!canBeMissing) throw "patch_sdk.dart expects all
inputs to exist $path";
The error could be a little clearer, e.g. to exist, missing: $path

[Siggi Cherem (dart-lang), 2017-08-30 23:05:06]

libraries.dart changes lgtm

[terry, 2017-08-31 03:07:24]

Description was changed from

==========
Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
==========

to

==========
Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
Committed:
https://github.com/dart-lang/sdk/commit/d96561af083777ac9529c75ae05b6e89f8f06a6c
==========

[terry, 2017-08-31 03:07:25]

Committed patchset #23 (id:220001) manually as
d96561af083777ac9529c75ae05b6e89f8f06a6c (presubmit successful).

[terry, 2017-08-31 14:17:30]

Description was changed from

==========
Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
Committed:
https://github.com/dart-lang/sdk/commit/d96561af083777ac9529c75ae05b6e89f8f06a6c
==========

to

==========
Removed Dartium SDK libs

First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a18908461adc431af2ee0114ed5ea9ef781bfb67
Committed:
https://github.com/dart-lang/sdk/commit/d96561af083777ac9529c75ae05b6e89f8f06a6c
Committed:
https://github.com/dart-lang/sdk/commit/4a5891838274ac53124acf6905c8ac9121978470
==========

[terry, 2017-08-31 14:17:32]

Committed patchset #28 (id:270001) manually as
4a5891838274ac53124acf6905c8ac9121978470 (presubmit successful).

[terry, 2017-08-31 14:29:30]

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (left):

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/BUILD.gn#o...
runtime/bin/BUILD.gn:185: 
On 2017/08/30 22:45:24, siva wrote:
> I think you should check with jacobr@ and matanl@ before removing support for
> these. Apparently there are some users in Google3 who like to run the command
> line dart against code that imports some of these html libraries.

I think I see your point we should be pointing to the dart2js versions of these
files and of course _blink and cached_patches don't exist in a non-Dartium
version so these are removed.

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/builtin.h
File runtime/bin/builtin.h (left):

https://codereview.chromium.org/3008563002/diff/210001/runtime/bin/builtin.h#...
runtime/bin/builtin.h:83: static const char* web_audio_source_paths_[];
On 2017/08/30 22:45:24, siva wrote:
> Ditto comment about removing these.

Only _blink_source_paths and cached_patches_source_paths are removed the others
stay.

https://codereview.chromium.org/3008563002/diff/210001/sdk/lib/html/html_comm...
File sdk/lib/html/html_common/html_common.dart (right):

https://codereview.chromium.org/3008563002/diff/210001/sdk/lib/html/html_comm...
sdk/lib/html/html_common/html_common.dart:26: part 'conversions_dart2js.dart';
On 2017/08/30 22:54:49, Alan Knight wrote:
> Wait, how did this work at all if it was explicitly importing the dartium
> version for both before?

The file conversion_dart2js.dart isn't needed but the conversion_dartium.dart is
gone.

https://codereview.chromium.org/3008563002/diff/210001/tests/lib/analyzer/ana...
File tests/lib/analyzer/analyze_library.status (left):

https://codereview.chromium.org/3008563002/diff/210001/tests/lib/analyzer/ana...
tests/lib/analyzer/analyze_library.status:26:
lib/js_util/dart2js/js_util_dart2js: CompileTimeError # Issue 16522
On 2017/08/30 22:54:49, Alan Knight wrote:
> How does removing Dartium code affect this?

Analyzing lib/js_util/dart2js/js_util_dart2js generates a CompileTimeError

ERROR|COMPILE_TIME_ERROR|IMPORT_INTERNAL_LIBRARY|/usr/local/google/home/terry/dart-sdk-git/sdk/sdk/lib/js_util/dart2js/js_util_dart2js.dart|12|1|38|The
library ''dart:_foreign_helper'' is internal and can't be imported.

this is no longer happening.  Not quite sure why?

https://codereview.chromium.org/3008563002/diff/210001/tools/patch_sdk.dart
File tools/patch_sdk.dart (right):

https://codereview.chromium.org/3008563002/diff/210001/tools/patch_sdk.dart#n...
tools/patch_sdk.dart:46: if (!canBeMissing) throw "patch_sdk.dart expects all
inputs to exist $path";
On 2017/08/30 22:54:49, Alan Knight wrote:
> The error could be a little clearer, e.g. to exist, missing: $path

Done.

[Alan Knight, 2017-08-31 17:09:52]

lgtm

https://codereview.chromium.org/3008563002/diff/210001/tests/lib/analyzer/ana...
File tests/lib/analyzer/analyze_library.status (left):

https://codereview.chromium.org/3008563002/diff/210001/tests/lib/analyzer/ana...
tests/lib/analyzer/analyze_library.status:26:
lib/js_util/dart2js/js_util_dart2js: CompileTimeError # Issue 16522
On 2017/08/31 14:29:30, terry wrote:
> On 2017/08/30 22:54:49, Alan Knight wrote:
> > How does removing Dartium code affect this?
> 
> Analyzing lib/js_util/dart2js/js_util_dart2js generates a CompileTimeError
> 
>
ERROR|COMPILE_TIME_ERROR|IMPORT_INTERNAL_LIBRARY|/usr/local/google/home/terry/dart-sdk-git/sdk/sdk/lib/js_util/dart2js/js_util_dart2js.dart|12|1|38|The
> library ''dart:_foreign_helper'' is internal and can't be imported.
> 
> this is no longer happening.  Not quite sure why?

OK, I have a theory. The reference to this in libraries.dart changed. It got
changed from the dartium version and the explicit path to the platform was
replaced. So possibly it was being (incorrectly, I think) analyzed as an
external library and unable to do the import, and now it's being seen as
internal, so the import is allowed.

[siva, 2017-08-31 17:22:37]

runtime/* changes LGTM