Removed Dartium SDK libs

runtime/bin/BUILD.gn

 # Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import("../../build/compiled_action.gni")
 import("../../sdk/lib/io/io_sources.gni")
 import("../runtime_args.gni")
 import("../vm/vm_sources.gni")
 import("builtin_impl_sources.gni")
 import("builtin_sources.gni")
@@ skipping 86 matching lines @@
   output = "$target_gen_dir/io_gen.cc"
 }
 
 gen_library_src_path("generate_io_patch_cc_file") {
   name = "io"
   kind = "patch"
   sources = io_runtime_sources
   output = "$target_gen_dir/io_patch_gen.cc"
 }
 
-gen_library_src_path("generate_html_cc_file") {
-  name = "html"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/html/dartium/html_dartium.dart",
-  ]
-  output = "$target_gen_dir/html_gen.cc"
-}
-
 gen_library_src_path("generate_html_common_cc_file") {
   name = "html_common"
   kind = "source"
   sources = [
     "../../sdk/lib/html/html_common/conversions.dart",
-    "../../sdk/lib/html/html_common/conversions_dartium.dart",
     "../../sdk/lib/html/html_common/css_class_set.dart",
     "../../sdk/lib/html/html_common/device.dart",
     "../../sdk/lib/html/html_common/filtered_element_list.dart",
     "../../sdk/lib/html/html_common/html_common.dart",
     "../../sdk/lib/html/html_common/lists.dart",
   ]
   output = "$target_gen_dir/html_common_gen.cc"
 }
 
-gen_library_src_path("generate_js_cc_file") {
-  name = "js"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/js/dartium/js_dartium.dart",
-  ]
-  output = "$target_gen_dir/js_gen.cc"
-}
-
-gen_library_src_path("generate_js_util_cc_file") {
-  name = "js_util"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/js_util/dartium/js_util_dartium.dart",
-  ]
-  output = "$target_gen_dir/js_util_gen.cc"
-}
-
-gen_library_src_path("generate_blink_cc_file") {
-  name = "_blink"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/_blink/dartium/_blink_dartium.dart",
-  ]
-  output = "$target_gen_dir/blink_gen.cc"
-}
-
-gen_library_src_path("generate_indexed_db_cc_file") {
-  name = "indexed_db"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/indexed_db/dartium/indexed_db_dartium.dart",
-  ]
-  output = "$target_gen_dir/indexed_db_gen.cc"
-}
-
-gen_library_src_path("generate_cached_patches_cc_file") {
-  name = "cached_patches"
-  library_name = "cached_patches.dart"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/js/dartium/cached_patches.dart",
-  ]
-  output = "$target_gen_dir/cached_patches_gen.cc"
-}
-
-gen_library_src_path("generate_web_gl_cc_file") {
-  name = "web_gl"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/web_gl/dartium/web_gl_dartium.dart",
-  ]
-  output = "$target_gen_dir/web_gl_gen.cc"
-}
-

[siva, 2017/08/30 22:45:24]

I think you should check with jacobr@ and matanl@ before removing support for
these. Apparently there are some users in Google3 who like to run the command
line dart against code that imports some of these html libraries.

[terry, 2017/08/31 14:29:30]

I think I see your point we should be pointing to the dart2js versions of these
files and of course _blink and cached_patches don't exist in a non-Dartium
version so these are removed.

 gen_library_src_path("generate_metadata_cc_file") {
   name = "metadata"
   library_name = "metadata.dart"
   kind = "source"
   sources = [
     "../../sdk/lib/html/html_common/metadata.dart",
   ]
   output = "$target_gen_dir/metadata_gen.cc"
 }
 
-gen_library_src_path("generate_web_sql_cc_file") {
-  name = "web_sql"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/web_sql/dartium/web_sql_dartium.dart",
-  ]
-  output = "$target_gen_dir/web_sql_gen.cc"
-}
-
-gen_library_src_path("generate_svg_cc_file") {
-  name = "svg"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/svg/dartium/svg_dartium.dart",
-  ]
-  output = "$target_gen_dir/svg_gen.cc"
-}
-
-gen_library_src_path("generate_web_audio_cc_file") {
-  name = "web_audio"
-  kind = "source"
-  sources = [
-    "../../sdk/lib/web_audio/dartium/web_audio_dartium.dart",
-  ]
-  output = "$target_gen_dir/web_audio_gen.cc"
-}
-
 config("libdart_builtin_config") {
   if (!is_win) {
     libs = [ "dl" ]
   }
   if (is_android) {
     libs += [
       "android",
       "log",
     ]
   }
 }
 
 template("build_libdart_builtin") {
   extra_configs = []
   if (defined(invoker.extra_configs)) {
     extra_configs += invoker.extra_configs
   }
   static_library(target_name) {
     configs += [ "..:dart_config" ] + extra_configs
     if (is_fuchsia) {
       configs -= [ "//build/config:symbol_visibility_hidden" ]
     }
     public_configs = [ ":libdart_builtin_config" ]
     deps = [
-      ":generate_blink_cc_file",
       ":generate_builtin_cc_file",
-      ":generate_cached_patches_cc_file",
-      ":generate_html_cc_file",
       ":generate_html_common_cc_file",
-      ":generate_indexed_db_cc_file",
       ":generate_io_cc_file",
       ":generate_io_patch_cc_file",
-      ":generate_js_cc_file",
-      ":generate_js_util_cc_file",
       ":generate_metadata_cc_file",
-      ":generate_svg_cc_file",
-      ":generate_web_audio_cc_file",
-      ":generate_web_gl_cc_file",
-      ":generate_web_sql_cc_file",
     ]
     include_dirs = [ ".." ]
     set_sources_assignment_filter([
                                     "*_test.cc",
                                     "*_test.h",
                                   ])
     sources = [
                 "log_android.cc",
                 "log_fuchsia.cc",
                 "log_linux.cc",
@@ skipping 521 matching lines @@
   }
 }
 
 dart_executable("dart_bootstrap") {
   extra_configs = [
     "..:dart_precompiler_config",
     "..:dart_no_snapshot_config",
   ]
   extra_deps = [
     ":gen_resources_cc",
-    ":generate_blink_cc_file",
     ":generate_builtin_cc_file",
-    ":generate_cached_patches_cc_file",
-    ":generate_html_cc_file",
     ":generate_html_common_cc_file",
-    ":generate_indexed_db_cc_file",
     ":generate_io_cc_file",
     ":generate_io_patch_cc_file",
-    ":generate_js_cc_file",
-    ":generate_js_util_cc_file",
     ":generate_metadata_cc_file",
-    ":generate_svg_cc_file",
-    ":generate_web_audio_cc_file",
-    ":generate_web_gl_cc_file",
-    ":generate_web_sql_cc_file",
     "..:libdart_nosnapshot_with_precompiler",
   ]
   extra_defines = [ "NO_OBSERVATORY" ]
   extra_sources = [
     "builtin.cc",
     "builtin.h",
     "dfe.cc",
     "dfe.h",
     "loader.cc",
     "loader.h",
     "gzip.cc",
     "gzip.h",
     "observatory_assets_empty.cc",
     "snapshot_empty.cc",
 
     # Include generated source files.
-    "$target_gen_dir/blink_gen.cc",
     "$target_gen_dir/builtin_gen.cc",
-    "$target_gen_dir/cached_patches_gen.cc",
     "$target_gen_dir/html_common_gen.cc",
-    "$target_gen_dir/html_gen.cc",
-    "$target_gen_dir/indexed_db_gen.cc",
     "$target_gen_dir/io_gen.cc",
     "$target_gen_dir/io_patch_gen.cc",
-    "$target_gen_dir/js_gen.cc",
-    "$target_gen_dir/js_util_gen.cc",
     "$target_gen_dir/metadata_gen.cc",
     "$target_gen_dir/resources_gen.cc",
-    "$target_gen_dir/svg_gen.cc",
-    "$target_gen_dir/web_audio_gen.cc",
-    "$target_gen_dir/web_gl_gen.cc",
-    "$target_gen_dir/web_sql_gen.cc",
   ]
 }
 
 if (is_fuchsia) {
   hello_fuchsia_source = rebase_path("../tests/vm/dart/hello_fuchsia_test.dart")
 
   copy("hello_fuchsia") {
     sources = [
       hello_fuchsia_source,
     ]
@@ skipping 187 matching lines @@
   ]
   if (is_linux || is_android) {
     cflags = [ "-fPIC" ]
   }
   if (is_win) {
     libs = [ "dart.lib" ]
     abs_root_out_dir = rebase_path(root_out_dir)
     ldflags = [ "/LIBPATH:$abs_root_out_dir" ]
   }
 }