|
|
Created:
6 years, 7 months ago by Yoav Weiss Modified:
6 years, 6 months ago Reviewers:
eseidel CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionClean up SizesAttributeParserTest and add some tests
BUG=357586
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175328
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
This removed a stale comment and a FIXME, and adds a bunch of test cases that were missing.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/9869) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9321) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9552)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9323)
The CQ bit was checked by yoav@yoav.ws
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
The CQ bit was unchecked by yoav@yoav.ws
On 2014/05/30 08:08:32, Yoav Weiss wrote: > The CQ bit was unchecked by mailto:yoav@yoav.ws The tests fail because of a bug in the handling of zero length source size. I've fixed it at https://codereview.chromium.org/302123002/ I'll land this CL after the fix has landed.
The CQ bit was checked by yoav@yoav.ws
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10202)
The CQ bit was unchecked by yoav@yoav.ws
The CQ bit was checked by yoav@yoav.ws
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
Message was sent while issue was closed.
Change committed as 175328 |