Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 300843008: Clean up SizesAttributeParserTest and add some tests (Closed)

Created:
6 years, 7 months ago by Yoav Weiss
Modified:
6 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up SizesAttributeParserTest and add some tests BUG=357586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/css/parser/SizesAttributeParserTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Yoav Weiss
This removed a stale comment and a FIXME, and adds a bunch of test cases ...
6 years, 7 months ago (2014-05-28 06:12:47 UTC) #1
eseidel
lgtm
6 years, 6 months ago (2014-05-28 22:44:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
6 years, 6 months ago (2014-05-28 22:44:53 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-28 23:03:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 23:14:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9323)
6 years, 6 months ago (2014-05-28 23:14:27 UTC) #6
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-05-30 07:42:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
6 years, 6 months ago (2014-05-30 07:43:47 UTC) #8
Yoav Weiss
The CQ bit was unchecked by yoav@yoav.ws
6 years, 6 months ago (2014-05-30 08:08:32 UTC) #9
Yoav Weiss
On 2014/05/30 08:08:32, Yoav Weiss wrote: > The CQ bit was unchecked by mailto:yoav@yoav.ws The ...
6 years, 6 months ago (2014-05-30 08:53:03 UTC) #10
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-06-02 17:38:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
6 years, 6 months ago (2014-06-02 17:38:31 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-02 18:59:53 UTC) #13
Yoav Weiss
The CQ bit was unchecked by yoav@yoav.ws
6 years, 6 months ago (2014-06-02 22:02:20 UTC) #14
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-06-02 22:02:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/300843008/1
6 years, 6 months ago (2014-06-02 22:03:04 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 01:49:47 UTC) #17
Message was sent while issue was closed.
Change committed as 175328

Powered by Google App Engine
This is Rietveld 408576698