dashboard/dashboard/pinpoint/models/quest/read_value_test.py - Issue 3008183002: [pinpoint] Separate Execution exceptions from result_values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/pinpoint/models/quest/read_value_test.py

Issue 3008183002: [pinpoint] Separate Execution exceptions from result_values. (Closed)

Patch Set: Fix exception loop Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/pinpoint/models/quest/read_value_test.py

diff --git a/dashboard/dashboard/pinpoint/models/quest/read_value_test.py b/dashboard/dashboard/pinpoint/models/quest/read_value_test.py

index f41ea71581c219927fb926b1c64a0806b910a1b3..1ef259e7bfd9f2ee819744f5d0306627ed5991bb 100644

--- a/dashboard/dashboard/pinpoint/models/quest/read_value_test.py

+++ b/dashboard/dashboard/pinpoint/models/quest/read_value_test.py

@@ -15,9 +15,8 @@ class _ReadValueTest(unittest.TestCase):

def assertReadValueError(self, execution):

self.assertTrue(execution.completed)

self.assertTrue(execution.failed)

- self.assertEqual(len(execution.result_values), 1)

- self.assertIsInstance(execution.result_values[0], basestring)

- last_exception_line = execution.result_values[0].splitlines()[-1]

+ self.assertIsInstance(execution.exception, basestring)

+ last_exception_line = execution.exception.splitlines()[-1]

self.assertTrue(last_exception_line.startswith('ReadValueError'))