Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py

Issue 3008183002: [pinpoint] Separate Execution exceptions from result_values. (Closed)
Patch Set: Fix exception loop Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py b/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
index 37132a997d8fc3dbf2ce6b06273904a5e4895307..f55fb42b4c7eabed686fad6a10a4f7699a715c03 100644
--- a/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
+++ b/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
@@ -44,16 +44,15 @@ class _FindIsolateTest(unittest.TestCase):
def assertExecutionFailure(self, execution, exception_class):
self.assertTrue(execution.completed)
self.assertTrue(execution.failed)
- self.assertEqual(len(execution.result_values), 1)
- self.assertIsInstance(execution.result_values[0], basestring)
- last_exception_line = execution.result_values[0].splitlines()[-1]
+ self.assertIsInstance(execution.exception, basestring)
+ last_exception_line = execution.exception.splitlines()[-1]
self.assertTrue(last_exception_line.startswith(exception_class.__name__))
self.assertEqual(execution.result_arguments, {})
def assertExecutionSuccess(self, execution):
self.assertTrue(execution.completed)
self.assertFalse(execution.failed)
- self.assertEqual(execution.result_values, (None,))
+ self.assertIsNone(execution.exception)
class IsolateLookupTest(_FindIsolateTest):
@@ -65,12 +64,14 @@ class IsolateLookupTest(_FindIsolateTest):
execution.Poll()
self.assertExecutionSuccess(execution)
+ self.assertEqual(execution.result_values, ())
self.assertEqual(execution.result_arguments, {'isolate_hash': '7c7e90be'})
self.assertEqual(
{
+ 'exception': None,
'build': None,
'result_arguments': {'isolate_hash': u'7c7e90be'},
- 'result_values': (None,)
+ 'result_values': (),
},
execution.AsDict())
« no previous file with comments | « dashboard/dashboard/pinpoint/models/quest/execution.py ('k') | dashboard/dashboard/pinpoint/models/quest/read_value_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698