Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: tests/compiler/dart2js/equivalence/id_equivalence_helper.dart

Issue 3008133002: Handle local invoke in inferrer (Closed)
Patch Set: dartfmt Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/equivalence/id_equivalence_helper.dart
diff --git a/tests/compiler/dart2js/equivalence/id_equivalence_helper.dart b/tests/compiler/dart2js/equivalence/id_equivalence_helper.dart
index b5b61af76e049f89135ce03bf2ea11f2057d4401..c9b36793c4e39ce9bd14e8b06c855d600770a93c 100644
--- a/tests/compiler/dart2js/equivalence/id_equivalence_helper.dart
+++ b/tests/compiler/dart2js/equivalence/id_equivalence_helper.dart
@@ -133,17 +133,15 @@ class IdData {
IdValue value = expectedMap[id];
if (data.value != value || value == null && data.value.value != '') {
String expected = value?.toString() ?? '';
+ int offset = getOffsetFromId(id);
annotations
- .putIfAbsent(data.sourceSpan.begin, () => [])
+ .putIfAbsent(offset, () => [])
.add('${expected} | ${data.value}');
}
});
expectedMap.forEach((Id id, IdValue expected) {
if (!actualMap.containsKey(id)) {
- int offset = compiler.reporter
- .spanFromSpannable(
- computeSpannable(elementEnvironment, mainUri, id))
- .begin;
+ int offset = getOffsetFromId(id);
annotations.putIfAbsent(offset, () => []).add('${expected} | ---');
}
});
@@ -171,6 +169,12 @@ class IdData {
});
return withAnnotations(annotations);
}
+
+ int getOffsetFromId(Id id) {
+ return compiler.reporter
+ .spanFromSpannable(computeSpannable(elementEnvironment, mainUri, id))
+ .begin;
+ }
}
/// Check code for all test files int [data] using [computeFromAst] and

Powered by Google App Engine
This is Rietveld 408576698