Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3008133002: Handle local invoke in inferrer (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle local invoke in inferrer

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 6

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -36 lines) Patch
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +3 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 1 5 chunks +69 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart View 1 2 2 chunks +79 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 5 chunks +11 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 2 chunks +9 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/inference/data/locals.dart View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
3 years, 3 months ago (2017-09-05 07:36:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm, neat! https://codereview.chromium.org/3008133002/diff/20001/pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart File pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart (right): https://codereview.chromium.org/3008133002/diff/20001/pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart#newcode349 pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart:349: Map<ir.Node, TypeMask> _sendMap; nit: TODO to rename? ...
3 years, 3 months ago (2017-09-05 19:20:39 UTC) #3
Johnni Winther
3 years, 3 months ago (2017-09-07 08:08:52 UTC) #4 
https://codereview.chromium.org/3008133002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart (right):

https://codereview.chromium.org/3008133002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart:349: Map<ir.Node,
TypeMask> _sendMap;
On 2017/09/05 19:20:39, Siggi Cherem (dart-lang) wrote:
> nit: TODO to rename? (I guess we also intend to rename typeOfSend, so that
will
> come at the same time?)

Done.

https://codereview.chromium.org/3008133002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/3008133002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:834: case CallType.complex:
On 2017/09/05 19:20:39, Siggi Cherem (dart-lang) wrote:
> because of the desugaring, I'm guessing complex is not going to be valid
> anymore, right?

Yes, I expect so.

https://codereview.chromium.org/3008133002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/inference/data/locals.dart (right):

https://codereview.chromium.org/3008133002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/inference/data/locals.dart:42: // ignore:
UNUSED_LOCAL_VARIABLE
On 2017/09/05 19:20:39, Siggi Cherem (dart-lang) wrote:
> should we disable running the analyzer on this data folder?

Maybe.

Powered by Google App Engine
This is Rietveld 408576698