Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3007743002: Add boxing for modified variables (Closed)

Created:
3 years, 3 months ago by Emily Fortuna
Modified:
3 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : boxing #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : .. #

Patch Set 5 : merged with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -263 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 2 3 4 9 chunks +46 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 1 2 7 chunks +9 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 2 3 4 4 chunks +96 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 3 4 4 chunks +2 lines, -9 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 3 chunks +0 lines, -5 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 2 3 4 6 chunks +2 lines, -10 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 4 41 chunks +66 lines, -115 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 2 3 4 8 chunks +13 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Emily Fortuna
3 years, 3 months ago (2017-08-29 21:52:56 UTC) #3
sra1
lgtm https://codereview.chromium.org/3007743002/diff/40001/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/3007743002/diff/40001/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode2192 pkg/compiler/lib/src/kernel/element_map_impl.dart:2192: /// are accessed in different scopes. This function ...
3 years, 3 months ago (2017-08-29 22:16:36 UTC) #4
Emily Fortuna
https://codereview.chromium.org/3007743002/diff/40001/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/3007743002/diff/40001/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode2192 pkg/compiler/lib/src/kernel/element_map_impl.dart:2192: /// are accessed in different scopes. This function creates ...
3 years, 3 months ago (2017-08-29 23:12:26 UTC) #5
Emily Fortuna
Committed patchset #5 (id:80001) manually as 98e36f719e1b95d7ddc986c676d1ac44100244c6 (presubmit successful).
3 years, 3 months ago (2017-08-29 23:27:34 UTC) #7
Emily Fortuna
3 years, 3 months ago (2017-08-29 23:32:04 UTC) #8
Message was sent while issue was closed. 
[+johnniwinther cc as FYI]

Powered by Google App Engine
This is Rietveld 408576698