Add boxing for modified variables

pkg/compiler/lib/src/kernel/element_map_impl.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.kernel.element_map;
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../closure.dart' show BoxLocal, ThisLocal;
 import '../common.dart';
@@ skipping 2150 matching lines @@
     FunctionData data = _memberData[function.memberIndex];
     data.forEachParameter(this, f);
   }
 
   void _forEachConstructorBody(
       IndexedClass cls, void f(ConstructorBodyEntity member)) {
     ClassEnv env = _classEnvs[cls.classIndex];
     env.forEachConstructorBody(f);
   }
 
+  JRecordField _constructBoxedField(
+      ir.VariableDeclaration variable,
+      BoxLocal boxLocal,
+      JClass container,
+      Map<String, MemberEntity> memberMap,
+      KernelToLocalsMap localsMap) {
+    Local local = localsMap.getLocalVariable(variable);
+    var boxedField = new JRecordField(
+        local.name, _memberData.length, boxLocal, container, variable.isConst);
+    _memberList.add(boxedField);
+    _memberData.add(new ClosureFieldData(new ClosureMemberDefinition(
+        boxedField,
+        computeSourceSpanFromTreeNode(variable),
+        MemberKind.closureField,
+        variable)));
+    memberMap[boxedField.name] = boxedField;
+
+    return boxedField;
+  }
+
+  /// Make a container controlling access to records, that is, variables that
+  /// are accessed in different scopes. This function creates the container as

[sra1, 2017/08/29 22:16:36]

'container as and' ?

[Emily Fortuna, 2017/08/29 23:12:26]

fixed

+  /// and returns a map of locals to the corresponding records created.
+  Map<Local, JRecordField> makeRecordContainer(
+      KernelScopeInfo info, MemberEntity member, KernelToLocalsMap localsMap) {
+    Map<Local, JRecordField> boxedFields = {};
+    if (info.boxedVariables.isNotEmpty) {
+      NodeBox box = info.capturedVariablesAccessor;
+
+      var container = new JRecord(member.library, _classEnvs.length, box.name);
+      _classList.add(container);
+      Map<String, MemberEntity> memberMap = <String, MemberEntity>{};
+      _classEnvs.add(new RecordEnv(memberMap));
+
+      var containerData = new ClassData(
+          null,
+          new ClosureClassDefinition(container,
+              computeSourceSpanFromTreeNode(getMemberDefinition(member).node)));
+      containerData
+        ..isMixinApplication = false
+        ..thisType = new InterfaceType(container, const <DartType>[])
+        ..supertype = commonElements.objectType
+        ..interfaces = const <InterfaceType>[];
+      var setBuilder = new _KernelOrderedTypeSetBuilder(this, container);
+      _classData.add(containerData);
+      containerData.orderedTypeSet = setBuilder.createOrderedTypeSet(
+          containerData.supertype, const Link<InterfaceType>());
+
+      BoxLocal boxLocal = new BoxLocal(box.name, member);
+      for (ir.VariableDeclaration variable in info.boxedVariables) {
+        boxedFields[localsMap.getLocalVariable(variable)] =
+            _constructBoxedField(
+                variable, boxLocal, container, memberMap, localsMap);
+      }
+    }
+    return boxedFields;
+  }
+
   KernelClosureClass constructClosureClass(
       MemberEntity member,
       ir.FunctionNode node,
       JLibrary enclosingLibrary,
+      Map<Local, JRecordField> boxedCapturedVariables,
       KernelScopeInfo info,
       ir.Location location,
       KernelToLocalsMap localsMap,
       InterfaceType supertype) {
     String name = _computeClosureName(node);
     JClass classEntity =
         new JClosureClass(enclosingLibrary, _classEnvs.length, name);
     _classList.add(classEntity);
     Map<String, MemberEntity> memberMap = <String, MemberEntity>{};
     _classEnvs.add(new ClosureClassEnv(memberMap));
@@ skipping 19 matching lines @@
     if (node.parent is ir.FunctionDeclaration) {
       ir.FunctionDeclaration parent = node.parent;
       closureEntity = localsMap.getLocalVariable(parent.variable);
     } else if (node.parent is ir.FunctionExpression) {
       closureEntity = new JLocal('', localsMap.currentMember);
     }
     Local thisLocal =
         info.hasThisLocal ? new ThisLocal(localsMap.currentMember) : null;
 
     KernelClosureClass cls = new KernelClosureClass.fromScopeInfo(
-        classEntity, node, info, localsMap, closureEntity, thisLocal);
-    int i = 0;
+        classEntity,
+        node,
+        <Local, JRecordField>{},
+        info,
+        localsMap,
+        closureEntity,
+        thisLocal);
+    int fieldNumber = 0;
     for (ir.VariableDeclaration variable in info.freeVariables) {
       // Make a corresponding field entity in this closure class for every
       // single freeVariable in the KernelScopeInfo.freeVariable.
-      _constructClosureFields(member, cls, memberMap, variable, i,
-          info.capturedVariablesAccessor, localsMap);
-      i++;
+      _constructClosureField(
+          member,
+          cls,
+          memberMap,
+          variable,
+          boxedCapturedVariables,
+          fieldNumber,
+          info.capturedVariablesAccessor,
+          localsMap);
+      fieldNumber++;
     }
 
     FunctionEntity callMethod = cls.callMethod = new JClosureCallMethod(
         _memberData.length,
         cls,
         _getParameterStructure(node),
         _getAsyncMarker(node));
     _memberList.add(cls.callMethod);
 
     _memberData.add(new ClosureFunctionData(
         new ClosureMemberDefinition(callMethod, closureData.definition.location,
             MemberKind.closureCall, node.parent),
         getFunctionType(node),
         node));
     memberMap[cls.callMethod.name] = cls.callMethod;
     return cls;
   }
 
-  _constructClosureFields(
+  _constructClosureField(
       MemberEntity member,
       KernelClosureClass cls,
       Map<String, MemberEntity> memberMap,
       ir.VariableDeclaration variable,
+      Map<Local, JRecordField> boxedCapturedVariables,
       int fieldNumber,
       NodeBox box,
       KernelToLocalsMap localsMap) {
     // NOTE: This construction order may be slightly different than the
     // old Element version. The old version did all the boxed items and then
     // all the others.
     Local capturedLocal = localsMap.getLocalVariable(variable);
-    if (cls.isBoxed(capturedLocal)) {
-      FieldEntity boxedField = new JRecordField(
-          _getClosureVariableName(capturedLocal.name, fieldNumber),
-          _memberData.length,
-          new BoxLocal(box.name,
-              localsMap.getLocalVariable(box.executableContext), member),
-          cls.closureClassEntity,
-          variable.isConst);
-      cls.localToFieldMap[capturedLocal] = boxedField;
-      _memberList.add(boxedField);
-      _memberData.add(new ClosureFieldData(new ClosureMemberDefinition(
-          boxedField,
-          computeSourceSpanFromTreeNode(variable),
-          MemberKind.closureField,
-          variable)));
-      memberMap[boxedField.name] = boxedField;
+    JRecordField record = boxedCapturedVariables[capturedLocal];

[sra1, 2017/08/29 22:16:36]

maybe call this 'field'

[Emily Fortuna, 2017/08/29 23:12:26]

done. yeah, there's some serious renaming I'll need to do again once this is all
done.

+    FieldEntity closureField = new JClosureField(
+        _getClosureVariableName(capturedLocal.name, fieldNumber),
+        _memberData.length,
+        cls,
+        variable.isConst,
+        variable.isFinal || variable.isConst);
+    _memberList.add(closureField);
+    _memberData.add(new ClosureFieldData(new ClosureMemberDefinition(
+        cls.localToFieldMap[capturedLocal],
+        computeSourceSpanFromTreeNode(variable),
+        MemberKind.closureField,
+        variable)));
+    memberMap[closureField.name] = closureField;
+    if (boxedCapturedVariables.containsKey(capturedLocal)) {
+      cls.localToFieldMap[record.box] = closureField;
+      cls.boxedVariables[capturedLocal] = record;
     } else {
-      FieldEntity closureField = new JClosureField(
-          _getClosureVariableName(capturedLocal.name, fieldNumber),
-          _memberData.length,
-          cls,
-          variable.isConst,
-          variable.isFinal || variable.isConst);
       cls.localToFieldMap[capturedLocal] = closureField;
-      _memberList.add(closureField);
-      _memberData.add(new ClosureFieldData(new ClosureMemberDefinition(
-          cls.localToFieldMap[capturedLocal],
-          computeSourceSpanFromTreeNode(variable),
-          MemberKind.closureField,
-          variable)));
-      memberMap[closureField.name] = closureField;
     }
   }
 
   // Returns a non-unique name for the given closure element.
   String _computeClosureName(ir.TreeNode treeNode) {
     var parts = <String>[];
     if (treeNode is ir.Field && treeNode.name.name != "") {
       parts.add(treeNode.name.name);
     } else {
       parts.add('closure');
@@ skipping 38 matching lines @@
   ///
   /// These names are not used in generated code, just as element name.
   String _getClosureVariableName(String name, int id) {
     return "_captured_${name}_$id";
   }
 
   String getDeferredUri(ir.LibraryDependency node) {
     throw new UnimplementedError('JsKernelToElementMap.getDeferredUri');
   }
 }