[VM generic function reification] Support generic functions in Invocation class.

[VM generic function reification] Support generic functions in Invocation class.
Make VM object TypeArguments a Dart instance.
Add a test verifying that noSuchMethod works with generic functions.

R=floitsch@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b3a7dd6e9dfab327a2ef4bb3ef729b4ba8661471

[regis, 2017-08-26 00:14:54]

regis@google.com changed reviewers:
+ floitsch@google.com, rmacnak@google.com

[floitsch, 2017-08-28 09:00:29]

API changes LGTM.

[rmacnak, 2017-08-28 18:29:46]

https://codereview.chromium.org/3007603002/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/3007603002/diff/1/runtime/vm/raw_object.h#new...
runtime/vm/raw_object.h:22: V(TypeArguments)                                    
                        \
This should appear after Instance to maintain the invariant that
obj.IsInstance() iff obj.cid() >= kInstanceCid. I suspect this will mean more
special cases elsewhere.

[regis, 2017-08-28 23:32:08]

PTAL

https://codereview.chromium.org/3007603002/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/3007603002/diff/1/runtime/vm/raw_object.h#new...
runtime/vm/raw_object.h:22: V(TypeArguments)                                    
                        \
On 2017/08/28 18:29:46, rmacnak wrote:
> This should appear after Instance to maintain the invariant that
> obj.IsInstance() iff obj.cid() >= kInstanceCid. I suspect this will mean more
> special cases elsewhere.

Done.
This required indeed the addition of many special cases. I guess the code is
cleaner now.

[rmacnak, 2017-08-28 23:48:58]

lgtm

https://codereview.chromium.org/3007603002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/3007603002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1162: if (subinstance_.IsInstance() &&
!subinstance_.IsTypeArguments()) {
This should do AddTypeArguments if for some reason the only use of some type is
as the function type argument to a call triggering NoSuchMethod.

[regis, 2017-08-28 23:56:58]

Thanks!

https://codereview.chromium.org/3007603002/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/3007603002/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1162: if (subinstance_.IsInstance() &&
!subinstance_.IsTypeArguments()) {
On 2017/08/28 23:48:58, rmacnak wrote:
> This should do AddTypeArguments if for some reason the only use of some type
is
> as the function type argument to a call triggering NoSuchMethod.

Done.

[regis, 2017-08-29 00:00:44]

Description was changed from

==========
[VM generic function reification] Support generic functions in Invocation class.
Make VM object TypeArguments a Dart instance.
Add a test verifying that noSuchMethod works with generic functions.
==========

to

==========
[VM generic function reification] Support generic functions in Invocation class.
Make VM object TypeArguments a Dart instance.
Add a test verifying that noSuchMethod works with generic functions.

R=floitsch@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b3a7dd6e9dfab327a2ef4bb3ef729b4ba8661471
==========

[regis, 2017-08-29 00:00:45]

Committed patchset #3 (id:40001) manually as
b3a7dd6e9dfab327a2ef4bb3ef729b4ba8661471 (presubmit successful).