Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: runtime/vm/object_graph.cc

Issue 3007603002: [VM generic function reification] Support generic functions in Invocation class. (Closed)
Patch Set: address review comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_graph.cc
diff --git a/runtime/vm/object_graph.cc b/runtime/vm/object_graph.cc
index 283143b74e9f3dc7653084381358fac9a0f2042c..25fc397e9912280d3afc5da139da4c4777614c0b 100644
--- a/runtime/vm/object_graph.cc
+++ b/runtime/vm/object_graph.cc
@@ -37,8 +37,8 @@ class ObjectGraph::Stack : public ObjectPointerVisitor {
if ((*current)->IsHeapObject() && !(*current)->IsMarked()) {
if (!include_vm_objects_) {
intptr_t cid = (*current)->GetClassId();
- if ((cid < kInstanceCid) && (cid != kContextCid) &&
- (cid != kFieldCid)) {
+ if (((cid < kInstanceCid) || (cid == kTypeArgumentsCid)) &&
+ (cid != kContextCid) && (cid != kFieldCid)) {
continue;
}
}
@@ -535,7 +535,8 @@ class WritePointerVisitor : public ObjectPointerVisitor {
// we'll need to encode which fields were omitted here.
continue;
}
- if (only_instances_ && (object->GetClassId() < kInstanceCid)) {
+ if (only_instances_ && ((object->GetClassId() < kInstanceCid) ||
+ (object->GetClassId() == kTypeArgumentsCid))) {
continue;
}
WritePtr(object, stream_);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698