Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3007443002: Use memory source files in compile_from_dill* (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 2 chunks +2 lines, -3 lines 2 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-23 14:11:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3007443002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (right): https://codereview.chromium.org/3007443002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart#newcode6 tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:6: // compilation. seems like we have misnomer now ...
3 years, 4 months ago (2017-08-23 20:51:08 UTC) #3
Johnni Winther
https://codereview.chromium.org/3007443002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (right): https://codereview.chromium.org/3007443002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart#newcode6 tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:6: // compilation. On 2017/08/23 20:51:08, Siggi Cherem (dart-lang) wrote: ...
3 years, 3 months ago (2017-08-30 08:53:19 UTC) #4
Johnni Winther
3 years, 3 months ago (2017-08-30 09:01:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ea293ae267c3484395a01d2392b359bf6e5269f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698