Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: tests/compiler/dart2js/kernel/compiler_helper.dart

Issue 3007443002: Use memory source files in compile_from_dill* (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/compiler_helper.dart
diff --git a/tests/compiler/dart2js/kernel/compiler_helper.dart b/tests/compiler/dart2js/kernel/compiler_helper.dart
index 9ee008fc34e14eabe8fc7be2ae14ad0c661aa4bd..7764c509f00463244ff1eb0d81c936dddb791da8 100644
--- a/tests/compiler/dart2js/kernel/compiler_helper.dart
+++ b/tests/compiler/dart2js/kernel/compiler_helper.dart
@@ -137,7 +137,7 @@ class MemoryKernelLibraryLoaderTask extends KernelLibraryLoaderTask {
MemoryKernelLibraryLoaderTask(KernelToElementMapForImpact elementMap,
DiagnosticReporter reporter, Measurer measurer, this.program)
- : super(null, elementMap, null, reporter, measurer);
+ : super(null, null, elementMap, null, reporter, measurer);
Future<LoadedLibraries> loadLibrary(Uri resolvedUri,
{bool skipFileWithPartOfTag: false}) async {
@@ -188,14 +188,12 @@ Future<Compiler> compileWithDill(
bool printSteps: false,
CompilerOutput compilerOutput,
void beforeRun(Compiler compiler)}) async {
- Uri dillFile =
- await generateDill(entryPoint, memorySourceFiles, printSteps: printSteps);
-
if (printSteps) {
- print('---- compile from dill $dillFile ---------------------------------');
+ print('---- compile from dill -------------------------------------------');
}
Compiler compiler = compilerFor(
- entryPoint: dillFile,
+ entryPoint: entryPoint,
+ memorySourceFiles: memorySourceFiles,
options: [Flags.useKernel]..addAll(options),
diagnosticHandler: diagnosticHandler,
outputProvider: compilerOutput);
@@ -204,6 +202,6 @@ Future<Compiler> compileWithDill(
if (beforeRun != null) {
beforeRun(compiler);
}
- await compiler.run(dillFile);
+ await compiler.run(entryPoint);
return compiler;
}

Powered by Google App Engine
This is Rietveld 408576698