Plumb trace canonicalUrl through TelemetryInfo.

Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans https://codereview.chromium.org/3008203002
- add traceUrls to CSVBuilder https://codereview.chromium.org/3005203002
- plumb traceUrls through ChartJsonConverter

BUG=catapult:#2431

Review-Url: https://chromiumcodereview.appspot.com/3007063002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8859dc2b7175d2c72a1fb1deebb3a0ca003aaa5b

[benjhayden, 2017-09-06 07:12:59]

Patchset #1 (id:1) has been deleted

[benjhayden, 2017-09-06 07:13:03]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2017-09-06 07:42:50]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2017-09-06 07:45:06]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, simonhatch@chromium.org

[benjhayden, 2017-09-06 07:48:00]

Description was changed from

==========
Plumb trace canonicalUrl through TelemetryInfo.

BUG=catapult:#2431
==========

to

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

A followup CL will format traceUrls generic-set-spans to take up less space.

BUG=catapult:#2431
==========

[benjhayden, 2017-09-06 15:53:41]

Description was changed from

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

A followup CL will format traceUrls generic-set-spans to take up less space.

BUG=catapult:#2431
==========

to

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans to take up less space.
- add traceUrls to CSVBuilder

BUG=catapult:#2431
==========

[benjhayden, 2017-09-06 17:49:35]

Description was changed from

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans to take up less space.
- add traceUrls to CSVBuilder

BUG=catapult:#2431
==========

to

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans https://codereview.chromium.org/3008203002
- add traceUrls to CSVBuilder

BUG=catapult:#2431
==========

[benjhayden, 2017-09-06 18:39:37]

Description was changed from

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans https://codereview.chromium.org/3008203002
- add traceUrls to CSVBuilder

BUG=catapult:#2431
==========

to

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans https://codereview.chromium.org/3008203002
- add traceUrls to CSVBuilder https://codereview.chromium.org/3005203002
- plumb traceUrls through ChartJsonConverter

BUG=catapult:#2431
==========

[eakuefner, 2017-09-06 21:39:38]

lgtm % test discussed offline.

[benjhayden, 2017-09-06 21:39:42]

https://codereview.chromium.org/3007063002/diff/60001/tracing/tracing/metrics...
File tracing/tracing/metrics/metric_map_function.html (right):

https://codereview.chromium.org/3007063002/diff/60001/tracing/tracing/metrics...
tracing/tracing/metrics/metric_map_function.html:76: throw new
Error(`canonicalUrl "${model.canonicalUrl}" != ` +
Test this

[benjhayden, 2017-09-06 23:01:18]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-09-06 23:01:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/3007063002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2017-09-06 23:01:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-06 23:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-06 23:24:58]

Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[benjhayden, 2017-09-07 04:08:43]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-09-07 04:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/3007063002/#ps100001
(title: "error handling")

[commit-bot: I haz the power, 2017-09-07 04:08:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-07 04:19:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 04:20:01]

Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[benjhayden, 2017-09-07 16:41:52]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-09-07 16:41:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/3007063002/#ps120001
(title: "fix csv pivot table test")

[commit-bot: I haz the power, 2017-09-07 16:41:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-07 16:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 16:55:50]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[benjhayden, 2017-09-07 18:28:05]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-09-07 18:28:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/3007063002/#ps160001
(title: "fix trace_unittest")

[commit-bot: I haz the power, 2017-09-07 18:28:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-07 18:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 18:32:39]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[benjhayden, 2017-09-07 22:33:37]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2017-09-07 22:33:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-07 23:06:18]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1504823617370630,
"parent_rev": "0d8b4db8b08f869dbe396a473003e8e05cedfc68", "commit_rev":
"8859dc2b7175d2c72a1fb1deebb3a0ca003aaa5b"}

[commit-bot: I haz the power, 2017-09-07 23:06:25]

Description was changed from

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans https://codereview.chromium.org/3008203002
- add traceUrls to CSVBuilder https://codereview.chromium.org/3005203002
- plumb traceUrls through ChartJsonConverter

BUG=catapult:#2431
==========

to

==========
Plumb trace canonicalUrl through TelemetryInfo.

Currently, trace canonical URLs are constructed after serializing the trace.
This prevents Histogram results from containing the canonical URL.
This CL constructs trace canonical URLs before serializing the trace so that
Histograms can contain the canonical URL.

Next CLs:
- format traceUrls generic-set-spans https://codereview.chromium.org/3008203002
- add traceUrls to CSVBuilder https://codereview.chromium.org/3005203002
- plumb traceUrls through ChartJsonConverter

BUG=catapult:#2431

Review-Url: https://chromiumcodereview.appspot.com/3007063002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-07 23:06:26]

Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[eakuefner, 2017-09-08 18:19:53]

A revert of this CL (patchset #6 id:160001) has been created in
https://chromiumcodereview.appspot.com/3007313002/ by eakuefner@chromium.org.

The reason for reverting is: Broke perf waterfall. Example stack trace:

Traceback (most recent call last):
  <module> at /b/swarming/w/ir/tools/perf/run_benchmark:26
    sys.exit(main())
  main at /b/swarming/w/ir/tools/perf/run_benchmark:22
    return benchmark_runner.main(config, [trybot_command.Trybot])
  main at
/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/benchmark_runner.py:352
    return command_instance.Run(options)
  Run at
/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/benchmark_runner.py:222
    return min(255, self._benchmark().Run(args))
  Run at
/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/benchmark.py:108
    return story_runner.RunBenchmark(self, finder_options)
  RunBenchmark at
/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:355
    results.UploadTraceFilesToCloud()
  UploadTraceFilesToCloud at
/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py:496
    value.UploadToCloud()
  UploadToCloud at
/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/value/trace.py:144
    self._upload_bucket, self._remote_path, fh.GetAbsPath())
  Insert at
/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py:378
    _RunCommand(command_and_args)
  _RunCommand at
/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py:153
    raise GetErrorObjectForCloudStorageStderr(stderr)
CloudStorageError: BucketNotFoundException: 404 gs://None bucket does not exist.

Locals:
  args       :
['/b/swarming/w/ir/third_party/catapult/third_party/gsutil/gsutil', 'cp',
'/b/swarming/w/it2IK7be/tmpRGMr7K.html', 'gs://None/None']
  gsutil     : <subprocess.Popen object at 0x7f0ff2972dd0>
  gsutil_env : None
  stderr     : 'BucketNotFoundException: 404 gs://None bucket does not exist.\n'
  stdout     : ''.