Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Issue 3005203002: Add traceUrls to CSVs. (Closed)

Created:
3 years, 3 months ago by benjhayden
Modified:
3 years, 3 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, rmistry1, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add traceUrls to CSVs. Currently, telemetry's deprecated csv-pivot-table output format contains trace URLs, but the replacement csv output format does not. This CL adds traceUrls to the new CSVs. Another CL will be required to plumb trace URLs through the chart json converter. BUG=catapult:#2431 Review-Url: https://chromiumcodereview.appspot.com/3005203002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/ed004dbd4b88856875b011150a523dd28675c764

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M telemetry/telemetry/internal/results/csv_output_formatter_unittest.py View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M tracing/tracing/value/csv_builder.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tracing/tracing/value/csv_builder_test.html View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
benjhayden
3 years, 3 months ago (2017-09-06 18:39:18 UTC) #2
eakuefner
lgtm
3 years, 3 months ago (2017-09-06 21:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005203002/1
3 years, 3 months ago (2017-09-06 21:56:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/9237)
3 years, 3 months ago (2017-09-06 22:19:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005203002/20001
3 years, 3 months ago (2017-09-06 22:35:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/9239)
3 years, 3 months ago (2017-09-06 22:46:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005203002/40001
3 years, 3 months ago (2017-09-07 03:45:58 UTC) #15
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 04:12:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698