Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 300693005: Make URLRequestFilter use URLRequestInterceptors. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 6 months ago
Reviewers:
pauljensen, sky
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, gavinp+prer_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Make URLRequestFilter use URLRequestInterceptors. It was using ProtocolHandlers, but it makes more sense for it to use the new URLRequestInterceptor class. BUG=146600 Committed: http://src.chromium.org/viewvc/chrome?revision=275470&view=revision

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Missed a spot #

Patch Set 4 : Fix stuff #

Patch Set 5 : Merge #

Patch Set 6 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -341 lines) Patch
M chrome/browser/component_updater/test/url_request_post_interceptor.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 3 4 5 30 chunks +95 lines, -100 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 8 chunks +18 lines, -21 lines 0 comments Download
M chrome/browser/net/load_timing_browsertest.cc View 5 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.cc View 4 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 14 chunks +41 lines, -45 lines 0 comments Download
M content/test/net/url_request_mock_http_job.h View 2 chunks +8 lines, -5 lines 0 comments Download
M content/test/net/url_request_mock_http_job.cc View 6 chunks +19 lines, -18 lines 0 comments Download
M content/test/net/url_request_prepackaged_interceptor.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/ocsp/nss_ocsp_unittest.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M net/url_request/url_request_filter.h View 4 chunks +21 lines, -23 lines 0 comments Download
M net/url_request/url_request_filter.cc View 8 chunks +59 lines, -58 lines 0 comments Download
M net/url_request/url_request_filter_unittest.cc View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
mmenke
Missed a spot
6 years, 6 months ago (2014-06-02 17:16:34 UTC) #1
mmenke
6 years, 6 months ago (2014-06-02 19:29:54 UTC) #2
mmenke
Oops... pauljensen: PTAL
6 years, 6 months ago (2014-06-02 19:30:56 UTC) #3
pauljensen
lgtm. Your find & replace must be tired :)
6 years, 6 months ago (2014-06-03 10:59:43 UTC) #4
mmenke
On 2014/06/03 10:59:43, pauljensen wrote: > lgtm. Your find & replace must be tired :) ...
6 years, 6 months ago (2014-06-03 14:15:35 UTC) #5
mmenke
jhawins: Mind signing off on the chrome/ changes? This is a purely mechanical refactoring, and ...
6 years, 6 months ago (2014-06-03 14:26:16 UTC) #6
mmenke
sky: Mind signing off on this? This is just replacing one abstract class with another, ...
6 years, 6 months ago (2014-06-06 14:24:36 UTC) #7
mmenke
On 2014/06/06 14:24:36, mmenke wrote: > sky: Mind signing off on this? This is just ...
6 years, 6 months ago (2014-06-06 14:25:24 UTC) #8
sky
LGTM
6 years, 6 months ago (2014-06-06 16:12:34 UTC) #9
mmenke
On 2014/06/06 16:12:34, sky wrote: > LGTM Thanks!
6 years, 6 months ago (2014-06-06 16:18:35 UTC) #10
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 6 months ago (2014-06-06 16:18:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/300693005/120001
6 years, 6 months ago (2014-06-06 16:19:57 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 17:37:09 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:46:09 UTC) #14
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 6 months ago (2014-06-06 17:46:10 UTC) #15
mmenke
6 years, 6 months ago (2014-06-06 17:54:07 UTC) #16
On 2014/06/06 17:46:10, I haz the power (commit-bot) wrote:
> Could not make sense out of svn commit message.

Hrm...This did in fact land.

Powered by Google App Engine
This is Rietveld 408576698