Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/extensions/user_script_listener_unittest.cc

Issue 300693005: Make URLRequestFilter use URLRequestInterceptors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/net/dns_probe_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/user_script_listener_unittest.cc
diff --git a/chrome/browser/extensions/user_script_listener_unittest.cc b/chrome/browser/extensions/user_script_listener_unittest.cc
index e14cb10c38c6b90e7f179abfeb48c1f532265103..65cb7e6ff7cd5abc7dc6dff66bc319011f4b12af 100644
--- a/chrome/browser/extensions/user_script_listener_unittest.cc
+++ b/chrome/browser/extensions/user_script_listener_unittest.cc
@@ -19,6 +19,7 @@
#include "net/base/request_priority.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_filter.h"
+#include "net/url_request/url_request_interceptor.h"
#include "net/url_request/url_request_test_job.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -101,21 +102,21 @@ scoped_refptr<Extension> LoadExtension(const std::string& filename,
Extension::NO_FLAGS, error);
}
-class SimpleTestJobProtocolHandler
- : public net::URLRequestJobFactory::ProtocolHandler {
+class SimpleTestJobURLRequestInterceptor
+ : public net::URLRequestInterceptor {
public:
- SimpleTestJobProtocolHandler() {}
- virtual ~SimpleTestJobProtocolHandler() {}
+ SimpleTestJobURLRequestInterceptor() {}
+ virtual ~SimpleTestJobURLRequestInterceptor() {}
// net::URLRequestJobFactory::ProtocolHandler
- virtual net::URLRequestJob* MaybeCreateJob(
+ virtual net::URLRequestJob* MaybeInterceptRequest(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const OVERRIDE {
return new SimpleTestJob(request, network_delegate);
}
private:
- DISALLOW_COPY_AND_ASSIGN(SimpleTestJobProtocolHandler);
+ DISALLOW_COPY_AND_ASSIGN(SimpleTestJobURLRequestInterceptor);
};
} // namespace
@@ -123,14 +124,14 @@ class SimpleTestJobProtocolHandler
class UserScriptListenerTest : public ExtensionServiceTestBase {
public:
UserScriptListenerTest() {
- net::URLRequestFilter::GetInstance()->AddHostnameProtocolHandler(
+ net::URLRequestFilter::GetInstance()->AddHostnameInterceptor(
"http", "google.com",
- scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>(
- new SimpleTestJobProtocolHandler()));
- net::URLRequestFilter::GetInstance()->AddHostnameProtocolHandler(
+ scoped_ptr<net::URLRequestInterceptor>(
+ new SimpleTestJobURLRequestInterceptor()));
+ net::URLRequestFilter::GetInstance()->AddHostnameInterceptor(
"http", "example.com",
- scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>(
- new SimpleTestJobProtocolHandler()));
+ scoped_ptr<net::URLRequestInterceptor>(
+ new SimpleTestJobURLRequestInterceptor()));
}
virtual ~UserScriptListenerTest() {
« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/net/dns_probe_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698