Land Recent QUIC Changes.

Land Recent QUIC Changes.

Changes StreamFramePacketOverhead to use offset in determining overhead.
Stream overhead changes as the offset changes.

Merge internal change: 67881361
https://codereview.chromium.org/304513006/


Fixes bugs in packet size computation in the creator and in the framer
mostly related to truncated ack size computation and verification. Fixes
a bug where sequence_number_length was incorrectly being allowed to
change mid-packet, and actively updates lengths in packets at
packet/FEC-group boundary. Adds tests to verify correct detection of ack
truncation.

Much yak hair was harvested, but no yaks were hurt in the making of
this CL.

Fixes bugs in packet-size computation in QuicPacketCreator and adds
tests.

Merge internal change: 67880898
https://codereview.chromium.org/300623009/


clang_tidy: remove redundant .get() calls on smart ptrs

Merge internal change: 67852120
https://codereview.chromium.org/304623002/


Update naming of members per style guideline with clang_tidy.
+ slowStart_  was changed to slow_start_.

Merge internal change: 67850333
https://codereview.chromium.org/300263003/


Added a helper function (SetIpInfoInCmsg) for WritePacket which fills in
the cmsg with the supplied self address.

This is part of "setting QoS on each quic sendmsg." internal CL.

Merge internal change: 67783235
https://codereview.chromium.org/300693006/


QUIC: rename GetWriteblockedStreams to GetWriteBlockedStreams.

Merge internal change: 67771815
https://codereview.chromium.org/302603007/


Change SendStreamId to take a stream ID argument in quic_session_test.cc

I think this makes the OnCanWriteBundlesStreams correct - it now writes
data with multiple stream IDs.

Also cleanup: use Invoke instead of InvokeWithoutArgs for calls which
have no args anyway...

Merge internal change: 67763247
https://codereview.chromium.org/307453006/


Rename QUIC's TransmissionInfo pending to in_flight and the associated
uses of pending in QuicUnackedPacketMap.

Merge internal change: 67762946
https://codereview.chromium.org/302783003/


Add a packet bundler in the internal server so that headers and body go
out in the same packet.

Tested by checking a small request is 1 packet; negative test fails.

Bundle headers with body in outgoing QUIC packets.

Merge internal change: 67729594
https://codereview.chromium.org/301563006/


Add an IncreaseLargestObserved to QuicUnackedPacketMap to remove the rtt
property from packets.

Merge internal change: 67725797
https://codereview.chromium.org/306573002/


Open a new port before closing the original in QUIC's port migration
EndToEndTest to ensure a new port is selected every time.

Merge internal change: 67703074
https://codereview.chromium.org/297213009/


Simplify QuicSentPacketManager MarkPacketHandled to take an iterator
instead of a sequence number and remove the case when it's called in
RetransmitUnackedPackets.

Merge internal change: 67652345
https://codereview.chromium.org/293383008/

R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273146

[Ryan Hamilton, 2014-05-28 00:30:37]

lgtm

[ramant (doing other things), 2014-05-28 00:31:43]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2014-05-28 00:32:25]

On 2014/05/28 00:30:37, Ryan Hamilton wrote:
> lgtm

Thanks very much Ryan,
raman

[commit-bot: I haz the power, 2014-05-28 00:32:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/300683008/1

[commit-bot: I haz the power, 2014-05-28 03:53:19]

Change committed as 273146

[wtc, 2014-05-28 19:02:50]

Patch set 1 LGTM.