Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: net/quic/quic_connection.cc

Issue 300683008: Land Recent QUIC Changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/time_loss_algorithm_test.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index e5fb0f80c98e0e0b8c36628370e8dd0b30f097df..8162c3c964dc98304587d17590f43edef5b75bcc 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1466,8 +1466,8 @@ bool QuicConnection::ShouldDiscardPacket(
if (retransmittable == HAS_RETRANSMITTABLE_DATA &&
!sent_packet_manager_.HasRetransmittableFrames(sequence_number)) {
- LOG(DFATAL) << ENDPOINT << "Dropping unacked packet: " << sequence_number
- << " This should have been removed when it was Neutered.";
+ DVLOG(1) << ENDPOINT << "Dropping unacked packet: " << sequence_number
+ << " A previous transmission was acked while write blocked.";
return true;
}
@@ -1944,7 +1944,11 @@ QuicConnection::ScopedPacketBundler::ScopedPacketBundler(
QuicConnection* connection,
AckBundling send_ack)
: connection_(connection),
- already_in_batch_mode_(connection->packet_generator_.InBatchMode()) {
+ already_in_batch_mode_(connection != NULL &&
+ connection->packet_generator_.InBatchMode()) {
+ if (connection_ == NULL) {
+ return;
+ }
// Move generator into batch mode. If caller wants us to include an ack,
// check the delayed-ack timer to see if there's ack info to be sent.
if (!already_in_batch_mode_) {
@@ -1962,6 +1966,9 @@ QuicConnection::ScopedPacketBundler::ScopedPacketBundler(
}
QuicConnection::ScopedPacketBundler::~ScopedPacketBundler() {
+ if (connection_ == NULL) {
+ return;
+ }
// If we changed the generator's batch state, restore original batch state.
if (!already_in_batch_mode_) {
DVLOG(1) << "Leaving Batch Mode.";
« no previous file with comments | « net/quic/congestion_control/time_loss_algorithm_test.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698