Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 30063003: Revert r160289 "Vibration cannot be canceled during pattern vibration." (Closed)

Created:
7 years, 2 months ago by pfeldman
Modified:
7 years, 2 months ago
Reviewers:
kihong
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Michael van Ouwerkerk, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Revert r160289 "Vibration cannot be canceled during pattern vibration." Breaks chromium.webkit: http://build.chromium.org/p/chromium.webkit/builders/WebKit Mac Builder/builds/64341 BUG= TBR=kihong.kwon@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160291

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -239 lines) Patch
D LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html View 1 chunk +0 lines, -64 lines 0 comments Download
D LayoutTests/vibration/cancel-vibration-during-pattern-vibrating-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/bindings/derived_sources.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/modules.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.cpp View 2 chunks +1 line, -3 lines 0 comments Download
D Source/modules/vibration/testing/InternalsVibration.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/modules/vibration/testing/InternalsVibration.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/modules/vibration/testing/InternalsVibration.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/web/web.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pfeldman
7 years, 2 months ago (2013-10-23 04:14:35 UTC) #1
pfeldman
Committed patchset #1 manually as r160291.
7 years, 2 months ago (2013-10-23 04:16:27 UTC) #2
kihong
On 2013/10/23 04:16:27, pfeldman wrote: > Committed patchset #1 manually as r160291. This problem looks ...
7 years, 2 months ago (2013-10-23 05:40:50 UTC) #3
Nils Barth (inactive)
On 2013/10/23 05:40:50, kihong wrote: > On 2013/10/23 04:16:27, pfeldman wrote: > > Committed patchset ...
7 years, 2 months ago (2013-10-23 07:14:39 UTC) #4
Nils Barth (inactive)
On 2013/10/23 07:14:39, Nils Barth wrote: > Figured out the problem; > it's dependency generation, ...
7 years, 2 months ago (2013-10-23 07:29:27 UTC) #5
kihong
7 years, 2 months ago (2013-10-23 07:47:07 UTC) #6
Message was sent while issue was closed.
On 2013/10/23 07:29:27, Nils Barth wrote:
> On 2013/10/23 07:14:39, Nils Barth wrote:
> > Figured out the problem;
> > it's dependency generation, due to minor GYP and regex errors.
> > Have a fix, will upload shortly.
> 
> Fixed in this CL:
> Fix IDL dependency computation for partial interfaces
> https://codereview.chromium.org/29323008/
> 
> Once that lands, we can reland the CL.

Yeah...Thanks~ Nils.

Powered by Google App Engine
This is Rietveld 408576698