Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 3006263002: Introduce RtcEvent and subclasses (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by eladalon
Modified:
5 days, 20 hours ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Introduce RtcEvent and subclasses We're moving to an RtcEventLog interface that accepts std::unique_ptr<EventLog> and stores the event for encoding when encoding becomes necessary, rather than before. This will be useful while we maintain the legacy (current) encoding alongside the new encoding on which we're working. This CL just introduces the new RtcEvent and its sub-classes, without constructors and without use. Upcoming CLs will finish the work. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : Remove two unused Type entries. #

Total comments: 10

Patch Set 3 : s/Header/Packet #

Patch Set 4 : Forgot some places. #

Patch Set 5 : . #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+976 lines, -0 lines) Patch
M webrtc/logging/BUILD.gn View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event.h View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_network_adaptation.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_playout.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_playout.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_receive_stream_config.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_receive_stream_config.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_send_stream_config.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_audio_send_stream_config.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_delay_based.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_delay_based.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_loss_based.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_bwe_update_loss_based.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_logging_started.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_logging_started.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_logging_stopped.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_logging_stopped.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_probe_cluster_created.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_probe_cluster_created.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_probe_result_failure.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_probe_result_failure.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_probe_result_success.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_probe_result_success.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_incoming.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_incoming.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_outgoing.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtcp_packet_outgoing.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_video_receive_stream_config.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_video_receive_stream_config.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_video_send_stream_config.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/events/rtc_event_video_send_stream_config.cc View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
eladalon
PTAL
1 week, 4 days ago (2017-09-08 17:11:27 UTC) #2
terelius
https://codereview.webrtc.org/3006263002/diff/20001/webrtc/logging/BUILD.gn File webrtc/logging/BUILD.gn (right): https://codereview.webrtc.org/3006263002/diff/20001/webrtc/logging/BUILD.gn#newcode46 webrtc/logging/BUILD.gn:46: "rtc_event_log/events/rtc_event_probe_result_failure.cc", Would it make sense to merge the probe_result_success ...
1 week, 2 days ago (2017-09-11 09:42:32 UTC) #3
eladalon
https://codereview.webrtc.org/3006263002/diff/20001/webrtc/logging/BUILD.gn File webrtc/logging/BUILD.gn (right): https://codereview.webrtc.org/3006263002/diff/20001/webrtc/logging/BUILD.gn#newcode46 webrtc/logging/BUILD.gn:46: "rtc_event_log/events/rtc_event_probe_result_failure.cc", On 2017/09/11 09:42:31, terelius wrote: > Would it ...
1 week, 1 day ago (2017-09-11 15:44:12 UTC) #4
eladalon
5 days, 20 hours ago (2017-09-14 15:00:53 UTC) #5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b