Move NetworkTypePattern to its own file

Move NetworkTypePattern to its own file

BUG=none
For trivial apps/shell/browser/ change:

R=pneubeck@chromium.org
TBR=derat@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273352

[stevenjb, 2014-05-27 22:37:42]

https://codereview.chromium.org/300623008/diff/1/chromeos/dbus/fake_shill_dev...
File chromeos/dbus/fake_shill_device_client.cc (right):

https://codereview.chromium.org/300623008/diff/1/chromeos/dbus/fake_shill_dev...
chromeos/dbus/fake_shill_device_client.cc:255: if (type == shill::kTypeCellular)
{
I don't think Shill client code should use NetworkTypePatern, that's a
NetworkState concept.

https://codereview.chromium.org/300623008/diff/1/chromeos/network/network_sta...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/300623008/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:22: #include
"chromeos/network/network_type_pattern.h"
Technically this can be forward declared, but since we are now using
NetworkTypePattern in so many function calls, this seems much more convenient
and easier to maintain.

[pneubeck (no reviews), 2014-05-28 08:04:02]

lgtm

https://codereview.chromium.org/300623008/diff/1/chromeos/network/network_sta...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/300623008/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:22: #include
"chromeos/network/network_type_pattern.h"
On 2014/05/27 22:37:43, stevenjb wrote:
> Technically this can be forward declared, but since we are now using
> NetworkTypePattern in so many function calls, this seems much more convenient
> and easier to maintain.
> 

As usual, my preference is explicitness and include-what-you-use to make it
easier for new developers to read this code and trace definitions.

[stevenjb, 2014-05-28 15:44:17]

https://codereview.chromium.org/300623008/diff/1/chromeos/network/network_sta...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/300623008/diff/1/chromeos/network/network_sta...
chromeos/network/network_state_handler.h:22: #include
"chromeos/network/network_type_pattern.h"
On 2014/05/28 08:04:02, pneubeck wrote:
> On 2014/05/27 22:37:43, stevenjb wrote:
> > Technically this can be forward declared, but since we are now using
> > NetworkTypePattern in so many function calls, this seems much more
convenient
> > and easier to maintain.
> > 
> 
> As usual, my preference is explicitness and include-what-you-use to make it
> easier for new developers to read this code and trace definitions.

In general I agree, but I think there is also confusion/overhead when two
includes (three actually) are required to call, e.g., ConnectedNetworkByType().
I regret (and may change at some point) not including network_handler.h in each
network*handler.h since there is no useful way to access one without the other
(except in tests).

[stevenjb, 2014-05-28 15:44:24]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-05-28 15:45:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/300623008/1

[commit-bot: I haz the power, 2014-05-28 16:16:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/9982)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/13071)

[commit-bot: I haz the power, 2014-05-28 16:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 16:21:08]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[stevenjb, 2014-05-28 20:46:23]

Committed patchset #2 manually as r273352 (presubmit successful).