chromeos/dbus/fake_shill_device_client.cc - Issue 300623008: Move NetworkTypePattern to its own file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_device_client.cc

Issue 300623008: Move NetworkTypePattern to its own file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_shill_device_client.cc

diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc

index ef88a1c69530dfcd99de90bf145518c2dc0f58a1..dd0322f7eb9c88123ff0c5c6a7793cd0ac9128bc 100644

--- a/chromeos/dbus/fake_shill_device_client.cc

+++ b/chromeos/dbus/fake_shill_device_client.cc

@@ -11,7 +11,6 @@

#include "chromeos/dbus/dbus_thread_manager.h"

#include "chromeos/dbus/shill_manager_client.h"

#include "chromeos/dbus/shill_property_changed_observer.h"

-#include "chromeos/network/shill_property_util.h"

#include "dbus/bus.h"

#include "dbus/message.h"

#include "dbus/object_path.h"

@@ -253,7 +252,7 @@ void FakeShillDeviceClient::AddDevice(const std::string& device_path,

properties->SetWithoutPathExpansion(

shill::kDBusServiceProperty,

base::Value::CreateStringValue(modemmanager::kModemManager1ServiceName));

- if (NetworkTypePattern::Cellular().MatchesType(type)) {

+ if (type == shill::kTypeCellular) {

properties->SetWithoutPathExpansion(shill::kCellularAllowRoamingProperty,

new base::FundamentalValue(false));

}

« no previous file with comments | « chromeos/chromeos.gyp ('k') | chromeos/network/managed_state.cc » ('j') | no next file with comments »