Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1985)

Unified Diff: pkg/analyzer/lib/src/fasta/ast_builder.dart

Issue 3005973002: Fix and triage more tests (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_fasta_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/fasta/ast_builder.dart
diff --git a/pkg/analyzer/lib/src/fasta/ast_builder.dart b/pkg/analyzer/lib/src/fasta/ast_builder.dart
index 8396f26ca1f006fdb6d0a3b7f023c1b172f09a74..6f05ef5b997073ad844f832771c6e49933aa0e27 100644
--- a/pkg/analyzer/lib/src/fasta/ast_builder.dart
+++ b/pkg/analyzer/lib/src/fasta/ast_builder.dart
@@ -1081,7 +1081,8 @@ class AstBuilder extends ScopeListener {
return token;
}
}
- return super.handleUnrecoverableError(token, message);
+ // TODO(brianwilkerson) After we've mapped all of the Fasta messages to
+ // analyzer messages, throw an error when we get to this point.
danrubel 2017/08/31 21:16:54 I prefer either throwing an error message or addin
Brian Wilkerson 2017/09/01 00:48:17 Ok, I've updated it to throw an exception, but I a
}
void handleUnaryPrefixExpression(Token token) {
@@ -1956,7 +1957,8 @@ class AstBuilder extends ScopeListener {
default:
// fall through
}
- library.addCompileTimeError(message, charOffset, uri);
+ // TODO(brianwilkerson) After we've mapped all of the Fasta messages to
+ // analyzer messages, throw an error when we get to this point.
danrubel 2017/08/31 21:16:54 Ditto.
}
/// A marker method used to mark locations where a token is being located in
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_fasta_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698