Fix and triage more tests

pkg/analyzer/lib/src/fasta/ast_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.analyzer.ast_builder;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/dart/ast/ast_factory.dart' show AstFactory;
 import 'package:analyzer/dart/ast/standard_ast_factory.dart' as standard;
 import 'package:analyzer/dart/ast/token.dart' show Token, TokenType;
@@ skipping 1063 matching lines @@
       String lexeme = token.lexeme;
       if (identical('async', lexeme) || identical('yield', lexeme)) {
         errorReporter?.reportErrorForOffset(
             ParserErrorCode.ASYNC_KEYWORD_USED_AS_IDENTIFIER,
             token.charOffset,
             token.charCount);
         push(ast.simpleIdentifier(token));
         return token;
       }
     }
-    return super.handleUnrecoverableError(token, message);
+    // TODO(brianwilkerson) After we've mapped all of the Fasta messages to
+    // analyzer messages, throw an error when we get to this point.

[danrubel, 2017/08/31 21:16:54]

I prefer either throwing an error message or adding a generic "not translated"
ParserErrorCode. A todo can get lost.

... but this is ok if you prefer

[Brian Wilkerson, 2017/09/01 00:48:17]

Ok, I've updated it to throw an exception, but I add a flag that can disable
this for testing purposes. If there's no throw then we get a specific list of
the errors that were expected / found, whereas a throw prevents us from
comparing the errors.

   }
 
   void handleUnaryPrefixExpression(Token token) {
     debugEvent("UnaryPrefixExpression");
     push(ast.prefixExpression(token, pop()));
   }
 
   void handleUnaryPrefixAssignmentExpression(Token token) {
     debugEvent("UnaryPrefixAssignmentExpression");
     push(ast.prefixExpression(token, pop()));
@@ skipping 854 matching lines @@
           errorReporter?.reportErrorForOffset(
               ParserErrorCode.EXPECTED_TOKEN, charOffset, text.length, [text]);
         } else {
           errorReporter?.reportErrorForOffset(ParserErrorCode.UNEXPECTED_TOKEN,
               charOffset, text.length, [text]);
         }
         return;
       default:
       // fall through
     }
-    library.addCompileTimeError(message, charOffset, uri);
+    // TODO(brianwilkerson) After we've mapped all of the Fasta messages to
+    // analyzer messages, throw an error when we get to this point.

[danrubel, 2017/08/31 21:16:54]

Ditto.

   }
 
   /// A marker method used to mark locations where a token is being located in
   /// an unsafe way. In all such cases the parser needs to be fixed to pass in
   /// the token.
   Token unsafeToken(Token token, TokenType tokenType) {
     // TODO(brianwilkerson) Eliminate the need for this method.
     return token.type == tokenType ? token : null;
   }
 }
@@ skipping 96 matching lines @@
       } else if (identical('var', s)) {
         finalConstOrVarKeyword = token;
       } else if (identical('covariant', s)) {
         covariantKeyword = token;
       } else {
         unhandled("$s", "modifier", token.charOffset, null);
       }
     }
   }
 }