Fix and triage more tests

Fix and triage more tests

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/47162b917447a01862c5a94b2c0c3b8c105d9ad3

[Brian Wilkerson, 2017-08-31 20:53:52]

brianwilkerson@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2017-08-31 21:16:54]

LGTM

https://codereview.chromium.org/3005973002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/3005973002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1085: // analyzer messages, throw an
error when we get to this point.
I prefer either throwing an error message or adding a generic "not translated"
ParserErrorCode. A todo can get lost.

... but this is ok if you prefer

https://codereview.chromium.org/3005973002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1961: // analyzer messages, throw an
error when we get to this point.
Ditto.

[Brian Wilkerson, 2017-09-01 00:48:17]

ptal

https://codereview.chromium.org/3005973002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/3005973002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1085: // analyzer messages, throw an
error when we get to this point.
Ok, I've updated it to throw an exception, but I add a flag that can disable
this for testing purposes. If there's no throw then we get a specific list of
the errors that were expected / found, whereas a throw prevents us from
comparing the errors.

[danrubel, 2017-09-01 14:50:11]

LGTM !

[Brian Wilkerson, 2017-09-01 14:52:08]

Description was changed from

==========
Fix and triage more tests
==========

to

==========
Fix and triage more tests

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/47162b917447a01862c5a94b2c0c3b8c105d9ad3
==========

[Brian Wilkerson, 2017-09-01 14:52:10]

Committed patchset #2 (id:20001) manually as
47162b917447a01862c5a94b2c0c3b8c105d9ad3 (presubmit successful).