Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 3005843002: Change presumbit to not provide unix-specific syntax on Windows. (Closed)

Created:
3 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 3 months ago
Reviewers:
Bill Hesse, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change presumbit to not provide unix-specific syntax on Windows.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
3 years, 3 months ago (2017-08-30 15:04:43 UTC) #2
Lasse Reichstein Nielsen
ping
3 years, 3 months ago (2017-09-04 07:43:45 UTC) #3
Bill Hesse
lgtm
3 years, 3 months ago (2017-09-04 08:19:57 UTC) #4
Bill Hesse
If this CL has been landed using Gerrit, then this review should be closed.
3 years, 3 months ago (2017-09-19 12:23:43 UTC) #5
Lasse Reichstein Nielsen
3 years, 3 months ago (2017-09-19 13:00:54 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698