Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: PRESUBMIT.py

Issue 3005843002: Change presumbit to not provide unix-specific syntax on Windows. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a71d7d55e1b98c03faced6e44430137da5b3768d..45d494c6c14f85de62bb1401c3103338145742fe 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -86,10 +86,14 @@ def _CheckDartFormat(input_api, output_api):
unformatted_files.append(filename)
if unformatted_files:
+ lineSep = ' \\\n'
+ if windows:
+ lineSep = ' ^\n'
return [output_api.PresubmitError(
'File output does not match dartfmt.\n'
'Fix these issues with:\n'
- '%s -w \\\n%s' % (prebuilt_dartfmt, ' \\\n'.join(unformatted_files)))]
+ '%s -w%s%s' % (prebuilt_dartfmt, lineSep,
+ lineSep.join(unformatted_files)))]
return []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698