Migrate block 115.

Migrate block 115.

Interesting changes:

- A static getter colliding with an inherited non-static setter is a
  compile error, not a type warning.

- Trying to call a setter on what is only a getter is a compile error
  with no runtime behavior.

- Add support to test.dart for negative tests in DDC.

BUG=
R=jcollins@google.com

Committed: https://github.com/dart-lang/sdk/commit/46320c52089858290c2f29b64fbddbc285d1e410

[Bob Nystrom, 2017-08-25 20:40:00]

Description was changed from

==========
Merge branch 'master' into migrate-115


Migrate block 115.

Interesting changes:

- A static getter colliding with an inherited non-static setter is a
  compile error, not a type warning.

- Trying to call a setter on what is only a getter is a compile error
  with no runtime behavior.

- Add support to test.dart for negative tests in DDC.

BUG=
==========

to

==========
Migrate block 115.

Interesting changes:

- A static getter colliding with an inherited non-static setter is a
  compile error, not a type warning.

- Trying to call a setter on what is only a getter is a compile error
  with no runtime behavior.

- Add support to test.dart for negative tests in DDC.

BUG=
==========

[Bob Nystrom, 2017-08-25 20:40:17]

rnystrom@google.com changed reviewers:
+ jcollins@google.com

[jcollins, 2017-08-25 20:59:45]

LGTM after nits addressed.

https://codereview.chromium.org/3005643002/diff/1/tests/language/language_dar...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/3005643002/diff/1/tests/language/language_dar...
tests/language/language_dart2js.status:1454:
variable_declaration_metadata_test/none: Crash
Why are all these lines added here?

https://codereview.chromium.org/3005643002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/3005643002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:217: hello_dart_test: Crash  # error:
expected: cls.is_type_finalized()
this is different than line 10?

[Bob Nystrom, 2017-08-28 23:17:31]

Description was changed from

==========
Migrate block 115.

Interesting changes:

- A static getter colliding with an inherited non-static setter is a
  compile error, not a type warning.

- Trying to call a setter on what is only a getter is a compile error
  with no runtime behavior.

- Add support to test.dart for negative tests in DDC.

BUG=
==========

to

==========
Migrate block 115.

Interesting changes:

- A static getter colliding with an inherited non-static setter is a
  compile error, not a type warning.

- Trying to call a setter on what is only a getter is a compile error
  with no runtime behavior.

- Add support to test.dart for negative tests in DDC.

BUG=
R=jcollins@google.com

Committed:
https://github.com/dart-lang/sdk/commit/46320c52089858290c2f29b64fbddbc285d1e410
==========

[Bob Nystrom, 2017-08-28 23:17:33]

Committed patchset #3 (id:40001) manually as
46320c52089858290c2f29b64fbddbc285d1e410.

[Bob Nystrom, 2017-08-28 23:18:50]

Thanks!

https://codereview.chromium.org/3005643002/diff/1/tests/language/language_dar...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/3005643002/diff/1/tests/language/language_dar...
tests/language/language_dart2js.status:1454:
variable_declaration_metadata_test/none: Crash
On 2017/08/25 20:59:45, jcollins wrote:
> Why are all these lines added here?

I don't know. Probably a merge mistake on my part. I'll clear them out.

https://codereview.chromium.org/3005643002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/3005643002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:217: hello_dart_test: Crash  # error:
expected: cls.is_type_finalized()
On 2017/08/25 20:59:45, jcollins wrote:
> this is different than line 10?

Doesn't look like it. Merged them.