| Index: tools/testing/dart/command_output.dart
|
| diff --git a/tools/testing/dart/command_output.dart b/tools/testing/dart/command_output.dart
|
| index db0c4a0759ad243b6a583e224e4c85211df85612..de1feefa7a78fb33d9778b3f7f26e5d02cabb697 100644
|
| --- a/tools/testing/dart/command_output.dart
|
| +++ b/tools/testing/dart/command_output.dart
|
| @@ -85,7 +85,6 @@ class CommandOutput extends UniqueObject {
|
| return !hasTimedOut && exitCode == 0;
|
| }
|
|
|
| - // TODO(bob): Remove.
|
| // Reverse result of a negative test.
|
| bool hasFailed(TestCase testCase) {
|
| return testCase.isNegative ? !_didFail(testCase) : _didFail(testCase);
|
| @@ -723,9 +722,9 @@ class DevCompilerCommandOutput extends CommandOutput {
|
| : Expectation.pass;
|
| }
|
|
|
| - // TODO(jmesserly): should we handle `testCase.isNegative`? Analyzer does
|
| - // not, so this behavior is chosen to match.
|
| - return exitCode == 0 ? Expectation.pass : Expectation.compileTimeError;
|
| + var outcome =
|
| + exitCode == 0 ? Expectation.pass : Expectation.compileTimeError;
|
| + return _negateOutcomeIfNegativeTest(outcome, testCase.isNegative);
|
| }
|
| }
|
|
|
|
|