Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 3005543002: Fix for chromeos enterprise tests. (Closed)

Created:
3 years, 4 months ago by achuithb
Modified:
3 years, 4 months ago
Reviewers:
sullivan, pfeldman
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fix for chromeos enterprise tests. ChromeOS enterprise tests restart the browser. We no longer have a fixed devtools port, so each restart requires us to reconnect to devtools, as in this CL: https://codereview.chromium.org/2993363002/ In the past, the devtools client continued to work, but it no longer does, and the test now needs to invoke WaitForBrowserToComeUp to reconnect to dev tools. BUG=chromium:755621 TEST=enterprise_RemoraRequisition Review-Url: https://codereview.chromium.org/3005543002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bc6176bd0422c6a26420334e66470bfa20fc9976

Patch Set 1 #

Patch Set 2 : Limit exposure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_browser_with_oobe.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
achuithb
Pavel, can you PTAL
3 years, 4 months ago (2017-08-24 19:46:37 UTC) #4
achuithb
Both Ned and Juan are out. Annie - could you PTAL?
3 years, 4 months ago (2017-08-24 19:49:52 UTC) #6
sullivan
lgtm
3 years, 4 months ago (2017-08-24 20:17:06 UTC) #9
achuithb
On 2017/08/24 20:17:06, sullivan wrote: > lgtm ty!
3 years, 4 months ago (2017-08-24 20:26:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005543002/20001
3 years, 4 months ago (2017-08-24 22:23:15 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 22:25:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698