Issue 300553009: Get rid of useSVGZoomRules in FontBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300553009: Get rid of useSVGZoomRules in FontBuilder (Closed)

Created:
6 years, 7 months ago by davve

Modified:
6 years, 6 months ago

Reviewers:

CC:
blink-reviews, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Get rid of useSVGZoomRules in FontBuilder First, having a flag such as useSVGZoomRules determined by the element type doesn't fit well with the way FontBuilder works. FontBuilder does nothing when there are no style affecting the font. No font is generated and no font size calculated. This means that unless a svg or foreignObject (borders between SVG and non-SVG) has one or more font related properties set, the useSVGZoomRules flag affects nothing already. But it turns out SVG finds out the font scale factor on its own by traversing ancestor chain anyway, so having a special case for SVG in FontBuilder is redundant, that font won't be used anyway, when the scale factor is different from 1.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -20 lines)			Patch
M	Source/core/css/resolver/FontBuilder.h	View	2	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/css/resolver/FontBuilder.cpp	View	1 2	2 chunks	+6 lines, -10 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 2	7 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Issue 300553009: Get rid of useSVGZoomRules in FontBuilder (Closed)

Description

Patch Set 1 #

Patch Set 2 : Keep text-only zoom feature; Android WebView uses it #

Patch Set 3 : Simplified patch by only including the removal of useSVGZoomRules and leave foreignObject issues fo… #