Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(677)

Issue 3005383002: Removing unused headers. (Closed)

Created:
7 months, 1 week ago by charujain1
Modified:
6 months, 3 weeks ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing unused headers. As part of enabling GN check, we figured out some of these headers are not included in any source file. Hence deleting them. BUG=webrtc:7620

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : upload empty headers #

Patch Set 4 : upload headers to test chromium trybots #

Patch Set 5 : Deleted again unused headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -135 lines) Patch
D webrtc/modules/video_coding/codecs/interface/mock/mock_video_codec_interface.h View 3 4 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/modules/video_coding/codecs/interface/video_codec_interface.h View 3 4 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/modules/video_coding/codecs/interface/video_error_codes.h View 3 4 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
charujain
Looks like chromium trybots are failing on patching. Seems to be bug in patch script ...
7 months, 1 week ago (2017-09-12 11:35:21 UTC) #3
mbonadei
On 2017/09/12 11:35:21, charujain wrote: > Looks like chromium trybots are failing on patching. Seems ...
7 months, 1 week ago (2017-09-12 11:45:41 UTC) #5
charujain1
On 2017/09/12 11:45:41, mbonadei wrote: > On 2017/09/12 11:35:21, charujain wrote: > > Looks like ...
7 months, 1 week ago (2017-09-13 08:30:03 UTC) #6
kjellander_webrtc
lgtm but the owner should know if it's safe to delete these. They're not used ...
7 months, 1 week ago (2017-09-13 08:35:02 UTC) #8
charujain1
On 2017/09/13 08:35:02, kjellander_webrtc wrote: > lgtm but the owner should know if it's safe ...
7 months, 1 week ago (2017-09-13 08:44:32 UTC) #9
mbonadei
On 2017/09/13 08:44:32, charujain1 wrote: > On 2017/09/13 08:35:02, kjellander_webrtc wrote: > > lgtm but ...
7 months, 1 week ago (2017-09-13 13:48:32 UTC) #10
kjellander_webrtc
On 2017/09/13 13:48:32, mbonadei wrote: > On 2017/09/13 08:44:32, charujain1 wrote: > > On 2017/09/13 ...
6 months, 3 weeks ago (2017-09-28 08:47:07 UTC) #11
charujain1
6 months, 3 weeks ago (2017-09-28 20:22:54 UTC) #12
On 2017/09/28 08:47:07, kjellander_webrtc wrote:
> On 2017/09/13 13:48:32, mbonadei wrote:
> > On 2017/09/13 08:44:32, charujain1 wrote:
> > > On 2017/09/13 08:35:02, kjellander_webrtc wrote:
> > > > lgtm but the owner should know if it's safe to delete these. They're not
> > used
> > > > downstream?
> > > 
> > > My bad. I totally forgot about google3 users.  
> > > Seems like many users in google3 depend on these headers. So we cannot
> delete
> > > them :( .
> > 
> > In this case I think we should add these headers into a GN target in
> > webrtc/modules/video_coding/BUILD.gn, even if it is unused now, if someone
> will
> > #include one of these in the future, GN will be able to ensure the
dependency
> > will be declared.
> 
> ping. This needs rebase too.

Since these headers are used internally, this CL is no more valid. Closing it.

Powered by Google App Engine
This is Rietveld 408576698