Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 300523003: Fix some problems with new reauth: (Closed)

Created:
6 years, 7 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 6 months ago
Reviewers:
guohui
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Fix some problems with new reauth: - use embedded view instead of servicelogin - don't show settings page when reauth'ing primary account - use new UMA action for logging reauth BUG=311235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273054

Patch Set 1 : Fix bool #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : rebased #

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M chrome/browser/signin/signin_promo.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 2 3 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 4 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Hui, Please take a look. Thanks.
6 years, 7 months ago (2014-05-24 03:30:44 UTC) #1
guohui
lgtm, thanks!
6 years, 6 months ago (2014-05-26 18:42:05 UTC) #2
guohui
https://codereview.chromium.org/300523003/diff/60001/chrome/browser/signin/signin_promo.cc File chrome/browser/signin/signin_promo.cc (right): https://codereview.chromium.org/300523003/diff/60001/chrome/browser/signin/signin_promo.cc#newcode254 chrome/browser/signin/signin_promo.cc:254: switches::IsNewProfileManagement()); nit: could you please add comment here? something ...
6 years, 6 months ago (2014-05-26 18:44:43 UTC) #3
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 6 months ago (2014-05-27 16:32:16 UTC) #4
Roger Tawa OOO till Jul 10th
Thanks Hui. https://codereview.chromium.org/300523003/diff/60001/chrome/browser/signin/signin_promo.cc File chrome/browser/signin/signin_promo.cc (right): https://codereview.chromium.org/300523003/diff/60001/chrome/browser/signin/signin_promo.cc#newcode254 chrome/browser/signin/signin_promo.cc:254: switches::IsNewProfileManagement()); On 2014/05/26 18:44:43, guohui wrote: > ...
6 years, 6 months ago (2014-05-27 16:32:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/300523003/100001
6 years, 6 months ago (2014-05-27 16:32:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-27 18:12:14 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-27 18:15:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/78032)
6 years, 6 months ago (2014-05-27 18:15:14 UTC) #9
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 6 months ago (2014-05-27 20:54:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/300523003/100001
6 years, 6 months ago (2014-05-27 20:56:27 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-27 22:27:53 UTC) #12
Message was sent while issue was closed.
Change committed as 273054

Powered by Google App Engine
This is Rietveld 408576698