Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 300523003: Fix some problems with new reauth: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 29 matching lines...) Expand all
40 40
41 const std::string& app_locale = g_browser_process->GetApplicationLocale(); 41 const std::string& app_locale = g_browser_process->GetApplicationLocale();
42 params.SetString("hl", app_locale); 42 params.SetString("hl", app_locale);
43 GaiaUrls* gaiaUrls = GaiaUrls::GetInstance(); 43 GaiaUrls* gaiaUrls = GaiaUrls::GetInstance();
44 params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec()); 44 params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec());
45 params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode); 45 params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);
46 46
47 const GURL& current_url = web_ui()->GetWebContents()->GetURL(); 47 const GURL& current_url = web_ui()->GetWebContents()->GetURL();
48 signin::Source source = signin::GetSourceForPromoURL(current_url); 48 signin::Source source = signin::GetSourceForPromoURL(current_url);
49 if (source == signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT || 49 if (source == signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT ||
50 source == signin::SOURCE_AVATAR_BUBBLE_SIGN_IN) { 50 source == signin::SOURCE_AVATAR_BUBBLE_SIGN_IN ||
51 source == signin::SOURCE_REAUTH) {
51 // Drop the leading slash in the path. 52 // Drop the leading slash in the path.
52 params.SetString( 53 params.SetString(
53 "gaiaPath", 54 "gaiaPath",
54 GaiaUrls::GetInstance()->embedded_signin_url().path().substr(1)); 55 GaiaUrls::GetInstance()->embedded_signin_url().path().substr(1));
55 } 56 }
56 57
57 params.SetString( 58 params.SetString(
58 "continueUrl", 59 "continueUrl",
59 signin::GetLandingURL("source", static_cast<int>(source)).spec()); 60 signin::GetLandingURL("source", static_cast<int>(source)).spec());
60 61
61 std::string default_email; 62 std::string default_email;
62 if (source != signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT) { 63 if (source != signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT &&
64 source != signin::SOURCE_REAUTH) {
63 default_email = Profile::FromWebUI(web_ui())->GetPrefs()->GetString( 65 default_email = Profile::FromWebUI(web_ui())->GetPrefs()->GetString(
64 prefs::kGoogleServicesLastUsername); 66 prefs::kGoogleServicesLastUsername);
65 } else { 67 } else {
66 if (!net::GetValueForKeyInQuery(current_url, "email", &default_email)) 68 if (!net::GetValueForKeyInQuery(current_url, "email", &default_email))
67 default_email.clear(); 69 default_email.clear();
68 } 70 }
69 if (!default_email.empty()) 71 if (!default_email.empty())
70 params.SetString("email", default_email); 72 params.SetString("email", default_email);
71 73
72 std::string frame_url; 74 std::string frame_url;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 main_frame_url = net::AppendOrReplaceQueryParameter( 107 main_frame_url = net::AppendOrReplaceQueryParameter(
106 main_frame_url, "frameUrl", base::UTF16ToASCII(url_str)); 108 main_frame_url, "frameUrl", base::UTF16ToASCII(url_str));
107 chrome::NavigateParams params( 109 chrome::NavigateParams params(
108 Profile::FromWebUI(web_ui()), 110 Profile::FromWebUI(web_ui()),
109 net::AppendOrReplaceQueryParameter(main_frame_url, "constrained", "0"), 111 net::AppendOrReplaceQueryParameter(main_frame_url, "constrained", "0"),
110 content::PAGE_TRANSITION_AUTO_TOPLEVEL); 112 content::PAGE_TRANSITION_AUTO_TOPLEVEL);
111 chrome::Navigate(&params); 113 chrome::Navigate(&params);
112 114
113 web_ui()->CallJavascriptFunction("inline.login.closeDialog"); 115 web_ui()->CallJavascriptFunction("inline.login.closeDialog");
114 } 116 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698