Issue 300523002: Don't expose --disable-gpu-compositing, only set internally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300523002: Don't expose --disable-gpu-compositing, only set internally. (Closed)

Created:
6 years, 7 months ago by piman

Modified:
6 years, 7 months ago

Reviewers:
jbauman

CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't expose --disable-gpu-compositing, only set internally. The flag isn't meant to be set externally, it doesn't work on most configs. It's only meant internally to make sure the renderer doesn't try to use GPU when the browser is in software. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272636

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -3 lines)			Patch
M	chrome/browser/chromeos/login/chrome_restart_request.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/300523002/1

6 years, 7 months ago (2014-05-23 20:43:27 UTC) #4

alph

6 years, 7 months ago (2014-05-24 09:21:31 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/299383002/ by alph@chromium.org.

The reason for reverting is: Makes a bunch of virtual/softwarecompositing tests
Timeout on Mac
https://code.google.com/p/chromium/issues/detail?id=377145.

Expand Messages | Collapse Messages